New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises/A Support #626

Merged
merged 1 commit into from May 20, 2013

Conversation

3 participants
@kevinbeaty
Contributor

kevinbeaty commented May 17, 2013

Issue #288

Added support for Promises/A to CustomEventEmitter Uses http://github.com/then/promise as it is bare bones compliant, and can be used with other compliant libraries (Q.when, when(), etc).

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented May 17, 2013

Travis fails it seems - It might be because you removed a dependency?

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented May 17, 2013

Actually seems like Travis is just complaining about a npm install, going to try rerunning

@sdepold

This comment has been minimized.

Member

sdepold commented May 20, 2013

yeah :)

sdepold added a commit that referenced this pull request May 20, 2013

@sdepold sdepold merged commit 1f313c1 into sequelize:master May 20, 2013

1 check passed

default The Travis CI build passed
Details

@kevinbeaty kevinbeaty deleted the kevinbeaty:emitpromise branch May 20, 2013

@durango durango referenced this pull request Jul 8, 2013

Closed

State of the Union #749

33 of 45 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment