hasMany setter uses bulk create and destroy to create and remove associations#690
Merged
durango merged 9 commits intosequelize:masterfrom Jun 11, 2013
Merged
Conversation
Member
|
Can you do me a favor and add some simple tests to this such as checking for the "IN" part on the deletion as well as multiple values for inserts? This is not because of your code, but just in case someone makes a change down the road that breaks this. |
spec/associations/has-many.spec.js
Outdated
durango
added a commit
that referenced
this pull request
Jun 11, 2013
hasMany setter uses bulk create and destroy to create and remove associations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #104
Since we now have bulk create and updates available, there is no reason to do individual queries for each object. Instead of
We will now do
And similarly for deletions:
Becomes