Skip to content

Added basic where logic to sequelize closes #321#727

Merged
janmeier merged 1 commit intosequelize:masterfrom
durango:logic
Jun 28, 2013
Merged

Added basic where logic to sequelize closes #321#727
janmeier merged 1 commit intosequelize:masterfrom
durango:logic

Conversation

@durango
Copy link
Copy Markdown
Member

@durango durango commented Jun 25, 2013

For more info:

#321

Basically allows us to do <, >, <=, >=, !=, between, and not between :)

Let me know if this is a suitable solution for you guys, we'll obviously need to write up documentation.

@janmeier
Copy link
Copy Markdown
Member

Looks pretty sweet! I wil have a proper look at the code later :)

Can it do multiple? As in combining for example lt and gt? If it does you might want to add a test for that

@durango
Copy link
Copy Markdown
Member Author

durango commented Jun 25, 2013

@janmeier you definitely can, it'll be in order though I'll add a test to it though just to double check :)

@durango
Copy link
Copy Markdown
Member Author

durango commented Jun 25, 2013

OK added :D

@sdepold
Copy link
Copy Markdown
Member

sdepold commented Jun 26, 2013

ooh yeeah 👯

@gu-stav
Copy link
Copy Markdown

gu-stav commented Jun 26, 2013

@durango Does that work for Date() aswell or only for strings?

@durango
Copy link
Copy Markdown
Member Author

durango commented Jun 27, 2013

Note: Don't pull this in yet..

@gustavpursche not sure actually, I'll throw it as a test shortly :)

@durango
Copy link
Copy Markdown
Member Author

durango commented Jun 28, 2013

OK, Date objects added, we look good to go :) Now onto better PRs

janmeier added a commit that referenced this pull request Jun 28, 2013
Added basic where logic to sequelize closes #321
@janmeier janmeier merged commit 3dacd3f into sequelize:master Jun 28, 2013
@gu-stav
Copy link
Copy Markdown

gu-stav commented Jun 28, 2013

@durango Thanks a lot - very good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants