New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic where logic to sequelize closes #321 #727

Merged
merged 1 commit into from Jun 28, 2013

Conversation

4 participants
@durango
Member

durango commented Jun 25, 2013

For more info:

#321

Basically allows us to do <, >, <=, >=, !=, between, and not between :)

Let me know if this is a suitable solution for you guys, we'll obviously need to write up documentation.

@janmeier

This comment has been minimized.

Member

janmeier commented Jun 25, 2013

Looks pretty sweet! I wil have a proper look at the code later :)

Can it do multiple? As in combining for example lt and gt? If it does you might want to add a test for that

@durango

This comment has been minimized.

Member

durango commented Jun 25, 2013

@janmeier you definitely can, it'll be in order though I'll add a test to it though just to double check :)

@durango

This comment has been minimized.

Member

durango commented Jun 25, 2013

OK added :D

@sdepold

This comment has been minimized.

Member

sdepold commented Jun 26, 2013

ooh yeeah 👯

@gustavpursche

This comment has been minimized.

Contributor

gustavpursche commented Jun 26, 2013

@durango Does that work for Date() aswell or only for strings?

@durango

This comment has been minimized.

Member

durango commented Jun 27, 2013

Note: Don't pull this in yet..

@gustavpursche not sure actually, I'll throw it as a test shortly :)

@durango

This comment has been minimized.

Member

durango commented Jun 28, 2013

OK, Date objects added, we look good to go :) Now onto better PRs

janmeier added a commit that referenced this pull request Jun 28, 2013

Merge pull request #727 from durango/logic
Added basic where logic to sequelize closes #321

@janmeier janmeier merged commit 3dacd3f into sequelize:master Jun 28, 2013

1 check passed

default The Travis CI build passed
Details
@gustavpursche

This comment has been minimized.

Contributor

gustavpursche commented Jun 28, 2013

@durango Thanks a lot - very good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment