Added basic where logic to sequelize closes #321#727
Merged
janmeier merged 1 commit intosequelize:masterfrom Jun 28, 2013
Merged
Added basic where logic to sequelize closes #321#727janmeier merged 1 commit intosequelize:masterfrom
janmeier merged 1 commit intosequelize:masterfrom
Conversation
Member
|
Looks pretty sweet! I wil have a proper look at the code later :) Can it do multiple? As in combining for example lt and gt? If it does you might want to add a test for that |
Member
Author
|
@janmeier you definitely can, it'll be in order though I'll add a test to it though just to double check :) |
Member
Author
|
OK added :D |
Member
|
ooh yeeah 👯 |
|
@durango Does that work for Date() aswell or only for strings? |
Member
Author
|
Note: Don't pull this in yet.. @gustavpursche not sure actually, I'll throw it as a test shortly :) |
Member
Author
|
OK, Date objects added, we look good to go :) Now onto better PRs |
janmeier
added a commit
that referenced
this pull request
Jun 28, 2013
Added basic where logic to sequelize closes #321
|
@durango Thanks a lot - very good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more info:
#321
Basically allows us to do <, >, <=, >=, !=, between, and not between :)
Let me know if this is a suitable solution for you guys, we'll obviously need to write up documentation.