New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For MySQL users, if their collation allows case insensitivity then allow enums to be case insensitive as well. Closes #627 #794

Merged
merged 3 commits into from Aug 3, 2013

Conversation

3 participants
@durango
Member

durango commented Jul 30, 2013

No description provided.

durango added some commits Jul 30, 2013

For MySQL users, if their collation allows case insensitivity then al…
…low enums to be case insensitive as well. Closes #627
Since pgsql and nodejs are both async, we'll need to add a delta to e…
…xpected times when setting the updatedAt.
@@ -85,6 +85,57 @@ if (dialect.match(/^mysql/)) {
})
})
describe.only('validations', function() {

This comment has been minimized.

@janmeier

janmeier Aug 1, 2013

Member

I'm not totally into the mocha syntax yet, but .only seems to mean that ONLY this test case is run :) ?

@durango

This comment has been minimized.

Member

durango commented Aug 1, 2013

@janmeier there u happy? :P Btw how you been man?

sdepold added a commit that referenced this pull request Aug 3, 2013

Merge pull request #794 from durango/enum-ci
For MySQL users, if their collation allows case insensitivity then allow enums to be case insensitive as well. Closes #627

@sdepold sdepold merged commit 85c231b into sequelize:master Aug 3, 2013

1 check passed

default The Travis CI build passed
Details

@durango durango deleted the durango:enum-ci branch Aug 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment