find a string based primaryKey called id#855
Merged
sdepold merged 3 commits intosequelize:masterfrom Aug 27, 2013
Merged
Conversation
Member
|
Are you sure this isn't already fixed in #master? I thought I added a PR for this a while back... |
Contributor
Author
|
I came across the problem yesterday... was just the extra check for id in dao-factory: (attributeName !== 'id')which wouldn't allow the primaryKeys to be populated |
Contributor
Author
|
Strange... Travis CI fails one test... but I don't think its related to this PR... any ideas what it is? |
Member
Github says its fine O-o |
Contributor
Author
|
Ya I pushed a teeny change in the PR to start travis again and it looks good now ;) |
|
Changes Unknown when pulling 82c3783 on whito:master into * on sequelize:master*. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using a String instead of an Integer for my id column ( I use a UUID ) and the find() function wasn't working. This pull request allows find to work when using a non-Integer based id instead of an Integer based id.