feat(model): allow serializing model instances into mongodb#8810
Closed
vkarpov15 wants to merge 1 commit into
Closed
feat(model): allow serializing model instances into mongodb#8810vkarpov15 wants to merge 1 commit into
vkarpov15 wants to merge 1 commit into
Conversation
Contributor
|
You can add a method to model instance, add var Model = Sequelize.define('Model', {
// various attributes
});
Model.prototype.toBSON = function () {
return this.toJSON();
} |
Author
|
I'm aware of that. However, I think it would be handy to have this functionality baked in to sequelize so end users don't have to think about it. Let me know, we can always just write a plugin instead. |
Contributor
|
Yeah, its better if this is handled at application code or as a plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Admittedly this is a strange PR, but we've seen instances of people trying to store sequelize objects in MongoDB (like agenda/agenda#562 (comment)). It would be handy if sequelize could implement a
toBSON()function so the mongodb driver could automatically serialize it correctly.Thanks and happy holidays!
Valeri