Skip to content

Features/mariadb#948

Merged
sdepold merged 29 commits intomasterfrom
features/mariadb
Oct 15, 2013
Merged

Features/mariadb#948
sdepold merged 29 commits intomasterfrom
features/mariadb

Conversation

@janmeier
Copy link
Copy Markdown
Member

@janmeier janmeier commented Oct 2, 2013

YES!

@sdepold
Copy link
Copy Markdown
Member

sdepold commented Oct 2, 2013

omg omg omg omg :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really be including this? Kind of like sqlite + pg...also master..? :/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mscdex has been pinged about the outlook of merging my PR

@sdepold
Copy link
Copy Markdown
Member

sdepold commented Oct 14, 2013

its still a tiny bit broken.

@sdepold
Copy link
Copy Markdown
Member

sdepold commented Oct 14, 2013

  961 passing (35s)
  4 failing

  1) [MARIADB] DAOFactory create is possible to use casting when creating an instance:
     Uncaught Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'INTEGER),'2013-10-14 21:04:04','2013-10-14 21:04:04')' at line 1


  2) [MARIADB] DAOFactory create is possible to use casting multiple times mixed in with other utilities:
     Uncaught Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'INTEGER) AS INTEGER),'2013-10-14 21:04:04','2013-10-14 21:04:04')' at line 1


  3) [MARIADB] DAOFactory create is possible to just use .literal() to bypass escaping:
     Uncaught Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'INTEGER),'2013-10-14 21:04:04','2013-10-14 21:04:04')' at line 1


  4) [MARIADB] DAOFactory create is possible for .literal() to contain other utility functions:
     Uncaught Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'INTEGER),'2013-10-14 21:04:04','2013-10-14 21:04:04')' at line 1

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by the way not related to mariadb, but fixes relative import on windows

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah :) good idea!

@sdepold sdepold merged commit 30991dd into master Oct 15, 2013
@sdepold
Copy link
Copy Markdown
Member

sdepold commented Oct 15, 2013

awesome work !

@janmeier janmeier deleted the features/mariadb branch July 18, 2014 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants