New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/mariadb #948

Merged
merged 29 commits into from Oct 15, 2013

Conversation

4 participants
@janmeier
Member

janmeier commented Oct 2, 2013

YES!

reedog117 and others added some commits May 2, 2013

@sdepold

This comment has been minimized.

Member

sdepold commented Oct 2, 2013

omg omg omg omg :)

@@ -57,7 +57,8 @@
"chai": "~1.8.0",
"mocha": "~1.13.0",
"chai-datetime": "~1.1.1",
"sinon": "~1.7.3"
"sinon": "~1.7.3",
"mariasql": "git://github.com/sequelize/node-mariasql.git"

This comment has been minimized.

@durango

durango Oct 3, 2013

Member

Should we really be including this? Kind of like sqlite + pg...also master..? :/

This comment has been minimized.

@janmeier

janmeier Oct 14, 2013

Member

mscdex has been pinged about the outlook of merging my PR

@sdepold

This comment has been minimized.

Member

sdepold commented Oct 14, 2013

its still a tiny bit broken.

@sdepold

This comment has been minimized.

Member

sdepold commented Oct 14, 2013

  961 passing (35s)
  4 failing

  1) [MARIADB] DAOFactory create is possible to use casting when creating an instance:
     Uncaught Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'INTEGER),'2013-10-14 21:04:04','2013-10-14 21:04:04')' at line 1


  2) [MARIADB] DAOFactory create is possible to use casting multiple times mixed in with other utilities:
     Uncaught Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'INTEGER) AS INTEGER),'2013-10-14 21:04:04','2013-10-14 21:04:04')' at line 1


  3) [MARIADB] DAOFactory create is possible to just use .literal() to bypass escaping:
     Uncaught Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'INTEGER),'2013-10-14 21:04:04','2013-10-14 21:04:04')' at line 1


  4) [MARIADB] DAOFactory create is possible for .literal() to contain other utility functions:
     Uncaught Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'INTEGER),'2013-10-14 21:04:04','2013-10-14 21:04:04')' at line 1
@@ -243,12 +245,11 @@ module.exports = (function() {
Sequelize.prototype.import = function(path) {
// is it a relative path?
if (url.parse(path).pathname.indexOf('/') !== 0) {
if (Path.normalize(path).indexOf(path.sep) !== 0) {

This comment has been minimized.

@janmeier

janmeier Oct 14, 2013

Member

This is by the way not related to mariadb, but fixes relative import on windows

This comment has been minimized.

@sdepold

sdepold Oct 15, 2013

Member

ah :) good idea!

@sdepold sdepold merged commit 30991dd into master Oct 15, 2013

1 check passed

default The Travis CI build passed
Details
@sdepold

This comment has been minimized.

Member

sdepold commented Oct 15, 2013

awesome work !

@janmeier janmeier deleted the features/mariadb branch Jul 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment