🐞 Keycloak/Admin Portal: Can't publish on tenants with passkeys - #2811
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts local-development base URLs from 127.0.0.1 to localhost in the Admin Portal/Voting Portal public settings and devcontainer environment configuration, aligning redirect/origin-related configuration with localhost usage (relevant for WebAuthn/passkey flows and browser-origin behavior).
Changes:
- Update Voting Portal
BALLOT_VERIFIER_URLinpublic/global-settings.jsonto usehttp://localhost:3001/. - Update Admin Portal
VOTING_PORTAL_URLinpublic/global-settings.jsonto usehttp://localhost:3000. - Update
.devcontainer/.env.developmentto uselocalhostforVOTING_PORTAL_URLandBALLOT_VERIFIER_URL.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/voting-portal/public/global-settings.json | Switch ballot verifier base URL to localhost in public runtime settings. |
| packages/admin-portal/public/global-settings.json | Switch voting portal base URL to localhost in public runtime settings. |
| .devcontainer/.env.development | Align devcontainer env vars for portal/verifier base URLs with localhost. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "APP_VERSION": "dev", | ||
| "APP_HASH": "dev", | ||
| "BALLOT_VERIFIER_URL": "http://127.0.0.1:3001/", | ||
| "BALLOT_VERIFIER_URL": "http://localhost:3001/", |
| }, | ||
| "PUBLIC_BUCKET_URL": "http://127.0.0.1:9002/public/", | ||
| "VOTING_PORTAL_URL": "http://127.0.0.1:3000", | ||
| "VOTING_PORTAL_URL": "http://localhost:3000", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/12279