🛡️ Parity-checks#41
Merged
Merged
Conversation
* Unit-tests now covers parity checks with upstream on CI/CD and local builds the snapshots are .gitignore'd and the emitted test-file are .Rbuildignore'd to limit the hurdles of CRAN policies and machines. A that passes on CI/CD and locally should be enough evidence that parity holds.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #41 +/- ##
==========================================
- Coverage 96.32% 96.27% -0.05%
==========================================
Files 272 272
Lines 20793 20793
==========================================
- Hits 20028 20019 -9
- Misses 765 774 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* If parity fails, the run fails. End of story.
serkor1
force-pushed
the
parity_checks
branch
2 times, most recently
from
1a0efb8 to
a8eb08d
Compare
Merged
serkor1
added a commit
that referenced
this pull request
Apr 25, 2026
## 📚 What? PR #48 introduced R-universe tests which is a more thorough testing scheme than the original `R-CMD-check` - there is no need to have have two workflows that tests the same thing. PR #41 introduced more thorough parity-checks which also renders the validity-checks obsolete. This PR introduces the following changes: * The old R-CMD-check is replaced with R-universe checks * The old validity checks are removed * The remote-install run is only triggered on changes to configure files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 What?
This PR introduces parity checks in {talib} against upstream TA-Lib and adjusts indicators where the parity fails for misaligned default arguments (these are considered minor changes, and can be a part of this PR). This PR changes the N of MAs from 10 to 30 (except T3 which uses 5), and changes the default MAType for MACDEXT to SMA (from EMA).
The parity-checks are not a part of the unit-tests on CRAN to avoid any issues related to builds, compilers and other exotic errors that may, or may not, be introduced when running such checks on machines you don't have any control over. All checks are done against the latest upstream and requires no snapshots, as it is expected that {talib} will follow upstream closely which is also why the built files are not tracked by Git.
Unit-tests will be generated as the
R CMD checkstarts, and deleted after the checks passes, or fails. The parity-checks will serve as the ultimate truth, and any deviations from it must be assumed to be a downstream bug (unless there is a posted issue upstream).