🧹 Cleanup GHA#49
Merged
Merged
Conversation
* With the introduction of R-universe checks the R-CMD-check is completely redundant.
* These validators were a sample validation routine that only tested against a small part of upstream. The approach taken here were too naive.
* Its basically R-CMD-check with extra steps. So for consistency this has been renamed.
* It should only run on changes to configure, if the package is broken it would be caught by the other runs.
* The original R-CMD-check is no longer needed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #49 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 280 280
Lines 21028 21028
=======================================
Hits 20307 20307
Misses 721 721 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 What?
PR #48 introduced R-universe tests which is a more thorough testing scheme than the original
R-CMD-check- there is no need to have have two workflows that tests the same thing. PR #41 introduced more thorough parity-checks which also renders the validity-checks obsolete.This PR introduces the following changes: