Skip to content

Conversation

@elbotho
Copy link
Member

@elbotho elbotho commented Nov 5, 2024

Follow ups:

  • migrate to eslint ^9 if eslint-plugin-import supports it
  • update eslint-config package code

@vercel
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Nov 12, 2024 1:17pm

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twenty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 87.17 KB (-1 B) 191.6 KB
/___bot_or_not 101.91 KB (-1 B) 206.33 KB
/___editor_preview 530.46 KB (🟡 +3 B) 634.88 KB
/biologie 155.77 KB (-1 B) 260.19 KB
/chemie 155.77 KB (-1 B) 260.19 KB
/content-only/[...slug] 79.22 KB (-1 B) 183.64 KB
/discussions 99.88 KB (-1 B) 204.3 KB
/editor 79.98 KB (-1 B) 184.4 KB
/entity/create/[type]/[taxonomyId] 550.56 KB (🟡 +3 B) 654.98 KB
/entity/repository/add-revision/[...id] 550.29 KB (🟡 +3 B) 654.71 KB
/entity/repository/compare/[entity_id]/[revision_id] 91.91 KB (-1 B) 196.33 KB
/informatik 155.77 KB (-1 B) 260.19 KB
/lerntipps 155.77 KB (-1 B) 260.19 KB
/license/detail/[id] 67.12 KB (-1 B) 171.55 KB
/mathe 155.77 KB (-1 B) 260.19 KB
/nachhaltigkeit 155.77 KB (-1 B) 260.2 KB
/page/create 550.27 KB (🟡 +3 B) 654.7 KB
/privacy 44.85 KB (-2 B) 149.27 KB
/taxonomy/term/create/[parent_id]/[id] 550.03 KB (🟡 +3 B) 654.46 KB
/taxonomy/term/update/[id] 549.98 KB (🟡 +3 B) 654.4 KB
/user/profile/[username] 178.73 KB (-1 B) 283.15 KB
/user/settings 551.95 KB (🟡 +3 B) 656.37 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@elbotho elbotho marked this pull request as ready for review November 12, 2024 13:47
@elbotho elbotho requested a review from hejtful November 12, 2024 13:47
@elbotho elbotho merged commit bffcf03 into staging Nov 12, 2024
8 checks passed
@elbotho elbotho deleted the chore/migrate-eslint branch November 12, 2024 13:52
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants