Skip to content

Conversation

@hejtful
Copy link
Contributor

@hejtful hejtful commented Dec 9, 2024

I introduced this bug while implementing the new arrow buttons functionality.

@hejtful hejtful requested a review from elbotho December 9, 2024 20:16
@vercel
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 9, 2024 8:19pm

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 637.17 KB (🟡 +17 B) 742.03 KB
/entity/create/[type]/[taxonomyId] 657.45 KB (🟡 +17 B) 762.31 KB
/entity/repository/add-revision/[...id] 657.18 KB (🟡 +17 B) 762.04 KB
/page/create 657.16 KB (🟡 +17 B) 762.03 KB
/taxonomy/term/create/[parent_id]/[id] 656.91 KB (🟡 +17 B) 761.78 KB
/taxonomy/term/update/[id] 656.86 KB (🟡 +17 B) 761.73 KB
/user/settings 658.83 KB (🟡 +17 B) 763.7 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@elbotho elbotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@hejtful hejtful merged commit 835bce9 into staging Dec 10, 2024
9 checks passed
@hejtful hejtful deleted the fix/dragging-spill branch December 10, 2024 08:03
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants