Skip to content

Conversation

@elbotho
Copy link
Member

@elbotho elbotho commented Dec 10, 2024

Basically a revert to fix https://serlo.slack.com/archives/C0BMSC431/p1733831189701459
Also some minor margin improvements.

Long term fix will be done in follow up (see discussion).

@elbotho elbotho requested a review from hejtful December 10, 2024 14:26
@vercel
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 10, 2024 2:28pm

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.87 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 637.17 KB (🟡 +9 B) 742.04 KB
/entity/create/[type]/[taxonomyId] 657.45 KB (🟡 +9 B) 762.32 KB
/entity/repository/add-revision/[...id] 657.19 KB (🟡 +9 B) 762.05 KB
/page/create 657.17 KB (🟡 +9 B) 762.04 KB
/taxonomy/term/create/[parent_id]/[id] 656.92 KB (🟡 +9 B) 761.79 KB
/taxonomy/term/update/[id] 656.87 KB (🟡 +9 B) 761.74 KB
/user/settings 658.84 KB (🟡 +9 B) 763.71 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@elbotho elbotho enabled auto-merge December 13, 2024 11:54
@elbotho elbotho merged commit 0129a9b into staging Dec 13, 2024
9 checks passed
@elbotho elbotho deleted the exercise-fixes branch December 13, 2024 13:02
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants