Feature/support tagging

[theburningmonk]

PR for #166 now that CloudFormation supports tagging for Step Functions

[noahw3]

Looks like this matches the cloudformation template exactly, but it might be nicer syntactically to define the tags as a dictionary (like how lambdas work) and then internally convert it to the array of key/value pairs?

Ie instead of

tags:
  -
    Key: keyname1
    Value: value1
  -
    Key: keyname2
    Value: value2

more like

tags:
  keyname1: value1
  keyname2: value2

[theburningmonk]

@noahw3 I thought about that too, but I have actually seen teams use : as delimiter in the key. There's nothing stopping us from still using : as delimiter though, e.g. my:namespace:for:tags:value => { Key: "my:namespace:for:tags", Value: "value" } but it might look a bit old.

But what if Value is an ARN which is also delimited by :? It would break our parsing. Open to suggestions as to how we might address that.

[noahw3]

If a special character is needed in the actual value (for either key or value), quoting it should be sufficient? YAML supports that.

tags:
  keyname1: "value1:append:all:the:things:with:colons:"
  "key:name2": value2

[noahw3]

Base serverless project implementation: https://github.com/serverless/serverless/blob/00d129ca86febcd960b17b19818ac413f7bee4d9/lib/plugins/aws/package/compile/functions/index.js#L135-L145

[theburningmonk]

@noahw3 ahh, I completely misunderstood you! You meant treat it as an object instead of array, of course, that makes sense :-D

[horike37]

LGTM @theburningmonk 👍 💯 and thank you for the suggestion @noahw3 😄

[theburningmonk]

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀