Improve "spin prune" and optimize SSH experience - #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR will address the following issues:
spin pruneis not clearing registry or Ansible collections cacheWe found that some cache files were being removed, but not everything. This PR ensures:
The local registry is no longer running as root
When users were running
spin deploy, it was starting the registry as the defaultrootuser within the container. We've now added the--userflag to set the registry to to run as the current running user id and group id. This improves experiences for running everything as an unprivileged user.Add support for SSH_AUTH_SOCK on Linux
We added the ability for the SSH Auth Socket to be set and work with Linux and WSL2 hosts.
Next steps
Before merging, I need to do the following:
spin pruneand then aspin deploymultiple times without permission issues