Conversation
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jdm
approved these changes
Feb 24, 2026
Member
jdm
left a comment
There was a problem hiding this comment.
This is nice! Just some copyediting suggestions.
Co-authored-by: Josh Matthews <josh@joshmatthews.net> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
mrobinson
requested changes
Feb 24, 2026
Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
mrobinson
approved these changes
Feb 25, 2026
Member
There was a problem hiding this comment.
Looks good, but one general note before landing. Each sentence should be a single line according to the book style guide (see https://book.servo.org/contributing/style-guide.html#servo-book). Please do that before landing. Thanks!
Minor nits below.
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Feb 26, 2026
Add a job to the release workflow which uploads a source code archive including our vendored rust dependencies. This allows offline builds after downloading the archive and will also be documented in the book (see servo/book#206). Testing: Manually tested by triggering a release on the nightly repo: https://github.com/servo/servo/actions/runs/22405488357/job/64863992613 --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Feb 26, 2026
Add a job to the release workflow which uploads a source code archive including our vendored rust dependencies. This allows offline builds after downloading the archive and will also be documented in the book (see servo/book#206). Testing: Manually tested by triggering a release on the nightly repo: https://github.com/servo/servo/actions/runs/22405488357/job/64863992613 --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Feb 26, 2026
Add a job to the release workflow which uploads a source code archive including our vendored rust dependencies. This allows offline builds after downloading the archive and will also be documented in the book (see servo/book#206). Testing: Manually tested by triggering a release on the nightly repo: https://github.com/servo/servo/actions/runs/22405488357/job/64863992613 --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
commented
Feb 26, 2026
| @@ -0,0 +1,46 @@ | |||
| # Building Offline | |||
|
|
|||
| Servo releases provide a `servo-<release-tag>-src-vendor.tar.gz` artifact which contains Servo's source code and all Rust dependencies vendored. | |||
Member
Author
There was a problem hiding this comment.
I updated the asset name to the one currently created by the release workflow. We can still change it. I'm not super happy with the src-vendor suffix, but I think we do need something to indicate that it contains both the sources and vendored sources. Open for suggestions. CC @mrobinson @jdm
jschwe
added a commit
to servo/servo
that referenced
this pull request
Feb 28, 2026
As suggested in servo/book#206 (comment) Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
jschwe
commented
Feb 28, 2026
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Feb 28, 2026
As suggested in servo/book#206 (comment) Testing: Not tested, just used grep. Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
shubhamg13
pushed a commit
to shubhamg13/servo
that referenced
this pull request
Mar 2, 2026
Add a job to the release workflow which uploads a source code archive including our vendored rust dependencies. This allows offline builds after downloading the archive and will also be documented in the book (see servo/book#206). Testing: Manually tested by triggering a release on the nightly repo: https://github.com/servo/servo/actions/runs/22405488357/job/64863992613 --------- Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
simonwuelker
pushed a commit
to simonwuelker/servo
that referenced
this pull request
Mar 3, 2026
As suggested in servo/book#206 (comment) Testing: Not tested, just used grep. Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v0.0.5 is the first release which contains the artifact (artifact uploaded manually, future releases will directly add it from CI)
Testing: