Bump MSRV to 1.71 #684
Merged
Bump MSRV to 1.71 #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Unblocks CI for #683 |
simonwuelker
force-pushed
the
msrv-fix
branch
from
a944e2e to
b3bb35d
Compare
Contributor
Author
simonwuelker
force-pushed
the
msrv-fix
branch
from
b3bb35d to
e92ae7f
Compare
simonwuelker
changed the title
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
simonwuelker
force-pushed
the
msrv-fix
branch
from
e92ae7f to
90b5e15
Compare
nicoburns
approved these changes
Oct 28, 2025
Contributor
nicoburns
left a comment
nicoburns
left a comment
There was a problem hiding this comment.
Yeah, our MSRV is plenty conservative. It's annoying that people bumping MSRV in semver-compatible versions means that the MSRV you choose is pretty meaningless, but that's where we are.
jdm
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our MSRV is 1.70, parking_lot 0.12.5 needs 1.71. I was not able to tell cargo to pick compatible versions for both
parking_lot,parking_lot_coreandlock_api. (We can pinparking_lotinCargo.tomlbut that seems to make cargo ignore the specified versions for the other two)1.71 was released in summer of 2023 so upgrading should not be a problem.