Skip to content

Comments

PlayerGLContext does not need to be thread aware#255

Merged
bors-servo merged 1 commit intoservo:masterfrom
ceyusa:trait-no-send
May 10, 2019
Merged

PlayerGLContext does not need to be thread aware#255
bors-servo merged 1 commit intoservo:masterfrom
ceyusa:trait-no-send

Conversation

@ceyusa
Copy link
Contributor

@ceyusa ceyusa commented May 9, 2019

Fixes: #251

As far as I have played, there's no need to make PlayerGLContext trait thread aware, so we could avoid the changes in #253

@ceyusa
Copy link
Contributor Author

ceyusa commented May 9, 2019

@ferjm r?

@ferjm
Copy link
Contributor

ferjm commented May 10, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 49e26d2 has been approved by ferjm

@bors-servo
Copy link
Contributor

⌛ Testing commit 49e26d2 with merge 121f943...

bors-servo pushed a commit that referenced this pull request May 10, 2019
PlayerGLContext does not need to be thread aware

Fixes: #251

As far as I have played, there's no need to make PlayerGLContext trait thread aware, so we could avoid the changes in #253
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: ferjm
Pushing 121f943 to master...

@bors-servo bors-servo merged commit 49e26d2 into servo:master May 10, 2019
@ceyusa ceyusa deleted the trait-no-send branch May 10, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build broken on Mac

3 participants