Make generate_wrappers work on dirty builds #400
Conversation
|
@redfire75369 can you check if it works for you. |
|
Yes, it works. Seems fine to me |
sagudev
force-pushed
the
fin-gen-wrap
branch
from
09fbf63 to
31e6097
Compare
|
Is it possible to refactor the call to find and the parsing of its output into a sh function in order to avoid so much duplication? |
sagudev
force-pushed
the
fin-gen-wrap
branch
from
31e6097 to
f3d42d0
Compare
|
I wish I had this idea before. |
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Looks good with one naming nit.
mozjs/src/generate_wrappers.sh
Outdated
| rustfmt target/jsapi.rs --config max_width=1000 | ||
| cp target/debug/build/mozjs-*/out/gluebindings.rs target/glue.rs | ||
| rustfmt target/glue.rs --config max_width=1000 | ||
| find_fmt_parse() { |
There was a problem hiding this comment.
How about find_latest_version_of_file_parse_and_format?
There was a problem hiding this comment.
That is so loooooong. Maybe just last_file_parse?
There was a problem hiding this comment.
Bits are very cheap. It is better to be verbose and obvious, rather than short and obscure. Many people will read this code in the future and it took me a bit to understand it.
There was a problem hiding this comment.
used long name and added usage comment and some more comments inside function
sagudev
force-pushed
the
fin-gen-wrap
branch
from
f3d42d0 to
2acdf94
Compare
|
Thank you! |
3 participants
Fixes #398