Clarify comment for parse_until_before; it also stops parsing at the end of the input. #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end of the input. Also add a test for this behavior. I was wondering about this myself, and figure it might save others time in the future.
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit ffb82d2 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jun 20, 2017
Clarify comment for parse_until_before; it also stops parsing at the end of the input. Also add a test for this behavior. I was wondering about this myself, and figure it might save others time in the future. Thanks for the library! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/161) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a test for this behavior. I was wondering about this myself, and figure it might save
others time in the future. Thanks for the library!
This change is