Include a SourceLocation in all error types #200
Merged
+263
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Oct 9, 2017
Member
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
Looks ok to me. I've skimmed the approach and taken a new look to the new macros and methods. Let me know if you want me to take a closer look at any particular part of the patch.
| location: self.current_source_location(), | ||
| } | ||
| } | ||
|
|
SimonSapin
force-pushed
the
location-in-errors
branch
from
f032e28 to
b0d4aa9
Compare
Member
Author
|
@bors-servo r+ |
Contributor
|
📌 Commit b0d4aa9 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Oct 10, 2017
Include a SourceLocation in all error types This is part of https://bugzilla.mozilla.org/show_bug.cgi?id=1378861 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/200) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of https://bugzilla.mozilla.org/show_bug.cgi?id=1378861
This change is