refactor: modularize CollectionAllocErr into errors.rs - #514
Open
yunaremaia wants to merge 1 commit into
Open
Conversation
Move CollectionAllocErr enum and its Display/Error impls from lib.rs to a dedicated src/errors.rs module, re-exporting it from lib.rs to preserve the public API. Fixes servo#513
alejandro-vaz
self-requested a review
August 30, 2026 19:10
alejandro-vaz
requested changes
Aug 30, 2026
Comment on lines
+1
to
+6
| // Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
| // http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
Collaborator
There was a problem hiding this comment.
no need to include this, it can be removed
Collaborator
|
you have to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modularizes
CollectionAllocErras requested in #513.src/errors.rscontaining theCollectionAllocErrenum and itsDisplay/Errorimplementationssrc/lib.rspub use errors::CollectionAllocErrto preserve the public APITesting
cargo checkpassescargo test --all-targetspasses (66 tests)CollectionAllocErrremains accessible assmallvec::CollectionAllocErrFixes #513