Support controlling interface and member visibility via preferences #10081

jdm · 2016-03-18T17:15:43Z

This was easier to throw together than per-attribute/method support, and it gets rid of some nonstandard properties from our globals.

Fixes #7626.

r? @Ms2ger

This change is

jdm · 2016-03-18T17:17:53Z

I discovered that in the case of:

[Pref="foo"]
interface Parent {}

interface Child : Parent {}

Parent still gets defined in the current implementation even if foo is false. What should we do in this case?

nox · 2016-03-19T15:21:51Z

Do you mean that Child still gets defined? Anyway whether it is parent or child I don't think either of them should be visible.

jdm · 2016-03-19T21:18:06Z

No, I mean that window.Parent is still defined even if the preference controlling it's visibility is false.

nox · 2016-03-20T10:18:02Z

Well that's obviously wrong, no?

larsbergstrom · 2016-03-23T19:23:39Z

👍 to `[Pref="dom.bluetooth.enabled"], and off by default.

cc @dati91

jdm · 2016-03-23T21:15:46Z

This is ready for review.

jdm · 2016-03-24T03:45:10Z

This is still ready for review; I just got carried away and implemented the Pref annotation for members of interfaces as well.

bors-servo · 2016-03-26T20:15:50Z

☔ The latest upstream changes (presumably #10204) made this pull request unmergeable. Please resolve the merge conflicts.

paulrouget · 2016-03-29T16:50:53Z

Can we get a review on that?

jdm · 2016-04-27T22:56:49Z

This has been ignored for more than a month. I would really appreciate if someone would take responsibility for reviewing my work :(

nox · 2016-04-29T09:04:21Z

On it.

Could you give more details about what you meant by "This was easier to throw together than per-attribute/method support"?

nox · 2016-04-29T09:06:42Z

@jdm I think you are cursed.

pkaminski · 2016-04-29T09:15:51Z

Hey @jdm, how did you make that happen? Reviewable thinks that somehow there's a discussion attached to a file that doesn't exist in the review, hence boom.

Comments from Reviewable

pkaminski · 2016-04-29T09:17:02Z

I mean @nox, sorry.

Comments from Reviewable

nox · 2016-04-29T09:18:18Z

@pkaminski I just clicked on the Reviewable button and it failed to load.

@jdm I don't get the purpose of avoiding JS_DefineProperties and friends, they just loop over items and call JS_DefineProperty sequentially. Couldn't we just rewrite JS_DefineProperties ourselves, putting a new field in JSPropertySpec or a similar structure?

nox · 2016-04-29T09:19:08Z

components/script/dom/bindings/codegen/CodegenRust.py

                else:
-                    properties[arrayName] = "&[]"
+                    properties[arrayName] = array.variableName()


Please revert this. It worked before and you didn't even document EMPTY_CONSTANTS.

highfive · 2016-05-02T18:19:31Z

  ▶ Unexpected subtest result in /_mozilla/mozilla/preferences.html:
  │ FAIL [expected PASS] prefs
  │   → TestBinding is not defined
  │ 
  │ @http://web-platform.test:8000/_mozilla/mozilla/preferences.html:2:6
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1397:20
  │ test@http://web-platform.test:8000/resources/testharness.js:495:9
  └ @http://web-platform.test:8000/_mozilla/mozilla/preferences.html:1:1


        Disable nonstandard interfaces via prefs.


        Forbid unconditionally-exposed interfaces that inherit from condition…

…ally-exposed ones.


        Ensure bluetooth and testbinding are disabled by default.


        Start generating arrays of specs for easier implementation of prefere…

…nce checks.


        Implement hiding of interface members via Pref annotations.


        Hide nonstandard interface members of standard interfaces behind appr…

…opriate prefs.


        Move FocusEvent into the right list of exposed interfaces.

jdm · 2016-05-02T18:33:29Z

@bors-servo: r=nox

bors-servo · 2016-05-02T18:33:30Z

📌 Commit 2a9bf70 has been approved by nox

bors-servo · 2016-05-02T18:35:39Z

⌛ Testing commit 2a9bf70 with merge 8255e74...


        Auto merge of #10081 - jdm:interfacepref, r=nox

@Ms2ger

Support controlling interface and member visibility via preferences This was easier to throw together than per-attribute/method support, and it gets rid of some nonstandard properties from our globals. Fixes #7626. r? @Ms2ger  --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10081)

bors-servo · 2016-05-02T19:45:34Z

💔 Test failed - linux-rel

highfive · 2016-05-02T19:45:36Z

  ▶ FAIL [expected PASS] /_mozilla/css/iframe/mozbrowser_navigation.html
  └   → /_mozilla/css/iframe/mozbrowser_navigation.html e60785ff75153e5d215bd0f65141fbb13cfbc61b
/_mozilla/css/iframe/mozbrowser_navigation_ref.html 8250706e506ad24231cc23be315b9b868387c598
Testing e60785ff75153e5d215bd0f65141fbb13cfbc61b == 8250706e506ad24231cc23be315b9b868387c598

cbrewster · 2016-05-02T19:57:27Z

@bors-servo retry

#10924

bors-servo · 2016-05-02T20:00:24Z

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...

bors-servo · 2016-05-02T20:40:42Z

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...

bors-servo · 2016-05-02T20:46:28Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

highfive assigned Ms2ger Mar 18, 2016

highfive added the S-awaiting-review label Mar 18, 2016

paulrouget mentioned this pull request Mar 21, 2016

forcetouch events #9811

Merged

larsbergstrom mentioned this pull request Mar 23, 2016

Implement WebBluetooth in Servo #9392

Closed

jdm force-pushed the jdm:interfacepref branch from e8f3b2e to 9afd906 Mar 23, 2016

jdm force-pushed the jdm:interfacepref branch from 41a29cc to 9cb157e Mar 23, 2016

jdm changed the title ~~Support controlling interface visibility via preferences~~ Support controlling interface and member visibility via preferences Mar 24, 2016

jdm force-pushed the jdm:interfacepref branch 2 times, most recently from 83e93ac to e06f60d Mar 24, 2016

highfive added the S-needs-rebase label Mar 26, 2016

jdm mentioned this pull request Apr 13, 2016

Implement non-visible pipeline and iframe visibility methods #10225

Merged

nox assigned nox and unassigned Ms2ger Apr 18, 2016

nox mentioned this pull request Apr 29, 2016

Unexpected crash on Servo PR Reviewable/Reviewable#299

Closed

nox reviewed Apr 29, 2016
View changes

jdm added 7 commits Mar 18, 2016

Disable nonstandard interfaces via prefs.

91a78ed

Forbid unconditionally-exposed interfaces that inherit from condition…

f4c1529

…ally-exposed ones.

Ensure bluetooth and testbinding are disabled by default.

693d31d

Start generating arrays of specs for easier implementation of prefere…

88059ac

…nce checks.

Implement hiding of interface members via Pref annotations.

cb5bad6

Hide nonstandard interface members of standard interfaces behind appr…

a03fc5e

…opriate prefs.

Move FocusEvent into the right list of exposed interfaces.

Loading status checks…

2a9bf70

jdm force-pushed the jdm:interfacepref branch from 48b2b50 to 2a9bf70 May 2, 2016

highfive added S-awaiting-review and removed S-tests-failed labels May 2, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels May 2, 2016

highfive removed the S-awaiting-merge label May 2, 2016

highfive added the S-tests-failed label May 2, 2016

highfive removed the S-awaiting-merge label May 2, 2016

This was referenced May 2, 2016

WebBluetooth impementation #10632

Merged

Issue #10605 generate unions from Typdefs inner type #10615

Closed

jdm mentioned this pull request May 20, 2016

Implement window.openURLInDefaultBrowser() #11292

Closed

servo / servo

Support controlling interface and member visibility via preferences #10081

Support controlling interface and member visibility via preferences #10081

jdm commented Mar 18, 2016

jdm commented Mar 18, 2016

nox commented Mar 19, 2016

jdm commented Mar 19, 2016

nox commented Mar 20, 2016

larsbergstrom commented Mar 23, 2016

jdm commented Mar 23, 2016

jdm commented Mar 24, 2016

bors-servo commented Mar 26, 2016

paulrouget commented Mar 29, 2016

jdm commented Apr 27, 2016

nox commented Apr 29, 2016

nox commented Apr 29, 2016

pkaminski commented Apr 29, 2016

pkaminski commented Apr 29, 2016

nox commented Apr 29, 2016

This comment has been minimized.

highfive commented May 2, 2016

jdm commented May 2, 2016

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

highfive commented May 2, 2016

cbrewster commented May 2, 2016 •

edited by jdm

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

servo / servo

Join GitHub today

Support controlling interface and member visibility via preferences #10081

Support controlling interface and member visibility via preferences #10081

Conversation

jdm commented Mar 18, 2016

jdm commented Mar 18, 2016

nox commented Mar 19, 2016

jdm commented Mar 19, 2016

nox commented Mar 20, 2016

larsbergstrom commented Mar 23, 2016

jdm commented Mar 23, 2016

jdm commented Mar 24, 2016

bors-servo commented Mar 26, 2016

paulrouget commented Mar 29, 2016

jdm commented Apr 27, 2016

nox commented Apr 29, 2016

nox commented Apr 29, 2016

pkaminski commented Apr 29, 2016

pkaminski commented Apr 29, 2016

nox commented Apr 29, 2016

This comment has been minimized.

nox Apr 29, 2016

highfive commented May 2, 2016

jdm commented May 2, 2016

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

highfive commented May 2, 2016

cbrewster commented May 2, 2016 • edited by jdm

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

bors-servo commented May 2, 2016

cbrewster commented May 2, 2016 •

edited by jdm