Skip to content

Checking the browsing_context before change title #10821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors-servo merged 1 commit into from
May 6, 2016
Merged

Checking the browsing_context before change title #10821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions components/script/dom/document.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,10 +618,12 @@ impl Document {

/// Handles any updates when the document's title has changed.
pub fn title_changed(&self) {
// https://developer.mozilla.org/en-US/docs/Web/Events/mozbrowsertitlechange
self.trigger_mozbrowser_event(MozBrowserEvent::TitleChange(String::from(self.Title())));
if self.browsing_context().is_some() {
// https://developer.mozilla.org/en-US/docs/Web/Events/mozbrowsertitlechange
self.trigger_mozbrowser_event(MozBrowserEvent::TitleChange(String::from(self.Title())));

self.send_title_to_compositor();
self.send_title_to_compositor();
}
}

/// Sends this document's title to the compositor.
Expand Down
6 changes: 6 additions & 0 deletions tests/wpt/mozilla/meta/MANIFEST.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6430,6 +6430,12 @@
"url": "/_mozilla/mozilla/mozbrowser/mozbrowsershowmodalprompt_event.html"
}
],
"mozilla/mozbrowser/mozbrowsertitlechangedeagerly_event.html": [
{
"path": "mozilla/mozbrowser/mozbrowsertitlechangedeagerly_event.html",
"url": "/_mozilla/mozilla/mozbrowser/mozbrowsertitlechangedeagerly_event.html"
}
],
"mozilla/mozbrowser/redirect.html": [
{
"path": "mozilla/mozbrowser/redirect.html",
Expand Down
19 changes: 19 additions & 0 deletions tests/wpt/mozilla/tests/mozilla/mozbrowser/mozbrowsertitlechangedeagerly_event.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!doctype html>
<meta charset="utf-8">
<title>Check if title_changed is too eager (issue #10782)</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<body></body>
<script>
async_test(function(t) {
var iframe = document.createElement("iframe");
iframe.mozbrowser = "true";
iframe.src = "mozbrowsertitlechangedeagerly_event_iframe.html";
iframe.addEventListener("mozbrowsertitlechange", t.step_func(e => {
assert_equals(e.type, "mozbrowsertitlechange");
assert_not_equals(e.detail, "Bar");
}));
iframe.addEventListener("load", t.step_func_done());
document.body.appendChild(iframe);
});
</script>
16 changes: 16 additions & 0 deletions tests/wpt/mozilla/tests/mozilla/mozbrowser/mozbrowsertitlechangedeagerly_event_iframe.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<html>
<head>
<title>Foo</title>
<script>
var text =
'<html xmlns="http://www.w3.org/1999/xhtml">' +
' <head>' +
' <title>Bar</title>' +
' </head>' +
'</html>';
var parser = new DOMParser();
var doc = parser.parseFromString(text, "text/xml");
</script>
</head>
<body>Hello world</body>
</html>