HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element. #13659

frewsxcv · 2016-10-09T17:37:33Z

Fixes #10520.

This change is

highfive · 2016-10-09T17:37:36Z

Heads up! This PR modifies the following files:

@KiChjang: components/script/dom/htmlelement.rs

highfive · 2016-10-09T17:37:37Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

frewsxcv · 2016-10-09T17:38:03Z

Anyone have suggestions where a regression test for this should live?

frewsxcv · 2016-10-09T17:38:07Z

@bors-servo try

bors-servo · 2016-10-09T17:38:10Z

⌛ Trying commit 8e1415e with merge 4c1b0f3...

HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element. Fixes #10520.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13659)

bors-servo · 2016-10-09T18:57:25Z

⛄ The build was interrupted to prioritize another pull request.

bors-servo · 2016-10-09T18:57:28Z

⌛ Trying commit 8e1415e with merge 43ed621...

HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element. Fixes #10520.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13659)

bors-servo · 2016-10-09T20:43:52Z

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev

Ms2ger · 2016-10-10T06:29:03Z

tests/wpt/web-platform-tests/cssom-view

frewsxcv · 2016-10-10T15:29:24Z

Possibly depends on w3c/csswg-drafts#584

frewsxcv · 2016-10-12T02:29:40Z

w3c/csswg-drafts#584 has been addressed (somewhat)

This is now dependent on #13708 in order for the regression test to work

…lement. Fixes servo#10520.

nox · 2016-11-30T22:38:38Z

components/script/dom/htmlelement.rs

@@ -272,9 +272,13 @@ impl HTMLElementMethods for HTMLElement {

    // https://drafts.csswg.org/cssom-view/#dom-htmlelement-offsetparent
    fn GetOffsetParent(&self) -> Option<Root<Element>> {
-        if self.is::<HTMLBodyElement>() || self.is::<HTMLHtmlElement>() {
+        if self.is::<HTMLHtmlElement>() {


This is incorrect, an html element can be the child of whatever. The test really needs to be about the root element.

Yep, sounds right. I'm going to assume I just call https://doc.servo.org/script/dom/element/struct.Element.html#method.root_element and check if it's the same as self

Should be better to compare self to its document's root element, rather than go up the whole hierarchy.

Or even, that self's parent is a Document.

frewsxcv · 2016-12-04T21:55:34Z

I don't really know what the next steps are here for this. Commit these changes with a failing test?

jdm · 2017-01-19T21:56:59Z

@bors-servo: try

bors-servo · 2017-01-19T21:57:04Z

⌛ Trying commit b109546 with merge 1c5f28e...

HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element. Fixes #10520.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13659)

bors-servo · 2017-01-19T22:16:11Z

💔 Test failed - linux-dev

jdm · 2017-01-19T22:50:01Z

error: no method named `is_root` found for type `&dom::element::Element` in the current scope
   --> /home/servo/buildbot/slave/linux-dev/build/components/script/dom/htmlelement.rs:278:69
    |
278 |         if self.is::<HTMLHtmlElement>() || self.upcast::<Element>().is_root() {
    |                                                                     ^^^^^^^

jdm · 2017-01-19T22:50:20Z

In theory the test shouldn't be failing anymore if the code compiles.

frewsxcv · 2017-01-20T01:06:07Z

Disclaimer: I'm not going to be able to get to this anytime soon if someone else wants to take over

nox · 2017-01-21T16:30:21Z

In theory the test shouldn't be failing anymore if the code compiles.

What test..?

jdm · 2017-01-22T14:00:11Z

I guess the regression test needs to be written again.

jdm · 2017-01-27T18:52:05Z

Let's close this since nobody's actively working on it.

highfive assigned metajack Oct 9, 2016

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 9, 2016

frewsxcv added S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 10, 2016

HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_e…

ee9a5b7

…lement. Fixes servo#10520.

frewsxcv force-pushed the the-html-body-element branch from 8e1415e to ee9a5b7 Compare November 4, 2016 18:55

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 4, 2016

nox reviewed Nov 30, 2016

View reviewed changes

Return null from offsetParent if root element.

b109546

highfive added the S-tests-failed The changes caused existing tests to fail. label Jan 19, 2017

jdm added the S-needs-new-owner The PR has been abandoned by the original author. label Jan 20, 2017

jdm mentioned this pull request Jan 27, 2017

HTMLElement::Offset{Parent,Left,Right} should call HTMLBodyElement::is_the_html_body_element #10520

Open

jdm closed this Jan 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element. #13659

HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element. #13659

frewsxcv commented Oct 9, 2016 •

edited by larsbergstrom

highfive commented Oct 9, 2016

highfive commented Oct 9, 2016

frewsxcv commented Oct 9, 2016

frewsxcv commented Oct 9, 2016

bors-servo commented Oct 9, 2016

bors-servo commented Oct 9, 2016

bors-servo commented Oct 9, 2016

bors-servo commented Oct 9, 2016

Ms2ger commented Oct 10, 2016

frewsxcv commented Oct 10, 2016

frewsxcv commented Oct 12, 2016

nox Nov 30, 2016 •

edited

frewsxcv Dec 1, 2016

nox Dec 1, 2016

nox Dec 1, 2016

frewsxcv Dec 1, 2016

frewsxcv commented Dec 4, 2016

jdm commented Jan 19, 2017

bors-servo commented Jan 19, 2017

bors-servo commented Jan 19, 2017

jdm commented Jan 19, 2017

jdm commented Jan 19, 2017

frewsxcv commented Jan 20, 2017

nox commented Jan 21, 2017

jdm commented Jan 22, 2017

jdm commented Jan 27, 2017

HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element. #13659

HTMLElement::Offset{Parent,Left,Right} should call is_the_html_body_element. #13659

Conversation

frewsxcv commented Oct 9, 2016 • edited by larsbergstrom

highfive commented Oct 9, 2016

highfive commented Oct 9, 2016

frewsxcv commented Oct 9, 2016

frewsxcv commented Oct 9, 2016

bors-servo commented Oct 9, 2016

bors-servo commented Oct 9, 2016

bors-servo commented Oct 9, 2016

bors-servo commented Oct 9, 2016

Ms2ger commented Oct 10, 2016

frewsxcv commented Oct 10, 2016

frewsxcv commented Oct 12, 2016

nox Nov 30, 2016 • edited

Choose a reason for hiding this comment

frewsxcv Dec 1, 2016

Choose a reason for hiding this comment

nox Dec 1, 2016

Choose a reason for hiding this comment

nox Dec 1, 2016

Choose a reason for hiding this comment

frewsxcv Dec 1, 2016

Choose a reason for hiding this comment

frewsxcv commented Dec 4, 2016

jdm commented Jan 19, 2017

bors-servo commented Jan 19, 2017

bors-servo commented Jan 19, 2017

jdm commented Jan 19, 2017

jdm commented Jan 19, 2017

frewsxcv commented Jan 20, 2017

nox commented Jan 21, 2017

jdm commented Jan 22, 2017

jdm commented Jan 27, 2017

frewsxcv commented Oct 9, 2016 •

edited by larsbergstrom

nox Nov 30, 2016 •

edited