Stylo: Add FFI interfaces for exposing style sources. by bradwerth · Pull Request #16328 · servo/servo

bradwerth · 2017-04-10T04:46:44Z

https://bugzilla.mozilla.org/show_bug.cgi?id=1346256
https://reviewboard.mozilla.org/r/119044/

This change is

highfive · 2017-04-10T04:46:50Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

highfive · 2017-04-10T04:46:50Z

Heads up! This PR modifies the following files:

@bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/gecko/arc_types.rs
@emilio: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, ports/geckolib/glue.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/gecko/arc_types.rs

highfive · 2017-04-10T04:46:51Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify style code, but no tests are modified. Please consider adding a test!

Manishearth · 2017-04-10T04:52:35Z

@bors-servo delegate+

use @bors-servo r=whoever to approve for landing

bors-servo · 2017-04-10T04:52:36Z

📌 Commit 549a6a0 has been approved by `whoever``

bors-servo · 2017-04-10T04:52:36Z

✌️ @bradwerth can now approve this pull request

bors-servo · 2017-04-10T04:52:40Z

⌛ Testing commit 549a6a0 with merge b84d079...

Stylo: Add FFI interfaces for exposing style sources. https://bugzilla.mozilla.org/show_bug.cgi?id=1346256 https://reviewboard.mozilla.org/r/119044/  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16328)

Manishearth · 2017-04-10T04:52:46Z

@bors-servo r=heycam

bors-servo · 2017-04-10T04:52:46Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Double number of WPT processes for Linux builders. #16327

bors-servo · 2017-04-10T04:52:46Z

📌 Commit 549a6a0 has been approved by heycam

bors-servo · 2017-04-10T04:52:50Z

⌛ Testing commit 549a6a0 with merge 661e1a51e4a560d329faff2214f34b2d7aa60f48...

Manishearth · 2017-04-10T04:53:05Z

@bors-servo r- retry clean r=heycam

bors-servo · 2017-04-10T04:53:06Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Double number of WPT processes for Linux builders. #16327

bors-servo · 2017-04-10T04:53:06Z

📌 Commit 549a6a0 has been approved by heycam

bors-servo · 2017-04-10T04:53:10Z

⌛ Testing commit 549a6a0 with merge 19203ec...

Stylo: Add FFI interfaces for exposing style sources. https://bugzilla.mozilla.org/show_bug.cgi?id=1346256 https://reviewboard.mozilla.org/r/119044/  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16328)

bors-servo · 2017-04-10T04:55:41Z

💔 Test failed - windows-msvc-dev

Manishearth · 2017-04-10T05:10:11Z

components/style/gecko_bindings/bindings.rs

                                          aSource: *const nsStyleFont);
 }
 extern "C" {
-    pub fn Gecko_GetBaseSize(lang: *mut nsIAtom) -> FontSizePrefs;


(undo this change)

Manishearth · 2017-04-10T05:10:31Z

error[E0432]: unresolved import `gecko_bindings::bindings::Gecko_GetBaseSize`
   --> C:\buildbot\slave\windows-msvc-dev\build\components\style\gecko\wrapper.rs:460:13
    |
460 |         use gecko_bindings::bindings::Gecko_GetBaseSize;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `Gecko_GetBaseSize` in `gecko_bindings::bindings`

error[E0432]: unresolved import `gecko_bindings::bindings::Gecko_GetBaseSize`
     --> c:\buildbot\slave\windows-msvc-dev\build\target\geckolib\debug\build\style-d5c8007cf63b1594\out/properties.rs:23716:21
      |
23716 |                 use gecko_bindings::bindings::Gecko_GetBaseSize;
      |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `Gecko_GetBaseSize` in `gecko_bindings::bindings`

error[E0412]: cannot find type `FontSizePrefs` in module `gecko_bindings::structs`
   --> C:\buildbot\slave\windows-msvc-dev\build\components\style\gecko\wrapper.rs:442:45
    |
442 |     pub font_size_cache: RefCell<Vec<(Atom, ::gecko_bindings::structs::FontSizePrefs)>>,
    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `gecko_bindings::structs`

error[E0412]: cannot find type `FontSizePrefs` in module `structs`
   --> C:\buildbot\slave\windows-msvc-dev\build\components\style\gecko\wrapper.rs:473:6
    |
473 | impl structs::FontSizePrefs {
    |      ^^^^^^^^^^^^^^^^^^^^^^ not found in `structs`

error[E0531]: cannot find unit struct/variant or constant `kPresContext_DefaultVariableFont_ID` in module `structs`
   --> C:\buildbot\slave\windows-msvc-dev\build\components\style\gecko\wrapper.rs:476:13
    |
476 |             structs::kPresContext_DefaultVariableFont_ID => self.mDefaultVariableSize,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `structs`

error[E0531]: cannot find unit struct/variant or constant `kPresContext_DefaultFixedFont_ID` in module `structs`
   --> C:\buildbot\slave\windows-msvc-dev\build\components\style\gecko\wrapper.rs:477:13
    |
477 |             structs::kPresContext_DefaultFixedFont_ID => self.mDefaultFixedSize,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `structs`

error: struct `RawServoStyleRule` is private
  --> C:\buildbot\slave\windows-msvc-dev\build\components\style\gecko\arc_types.rs:12:52
   |
12 | use gecko_bindings::bindings::{RawServoStyleSheet, RawServoStyleRule, RawServoImportRule};
   |                                                    ^^^^^^^^^^^^^^^^^

error: the type of this value must be known in this context
   --> C:\buildbot\slave\windows-msvc-dev\build\components\style\gecko\wrapper.rs:462:30
    |
462 |         if let Some(sizes) = cache.iter().find(|el| el.0 == *font_name) {
    |                              ^^^^^^^^^^^^

error: aborting due to previous error

Manishearth · 2017-04-10T05:10:48Z

components/style/gecko_bindings/bindings.rs

 use gecko_bindings::structs::ComputedTimingFunction_BeforeFlag;
 use gecko_bindings::structs::FontFamilyList;
 use gecko_bindings::structs::FontFamilyType;
-use gecko_bindings::structs::FontSizePrefs;


undo this change

bradwerth · 2017-04-10T08:16:40Z

@bors-servo r=heycam

bors-servo · 2017-04-10T08:16:41Z

📌 Commit 4a9ac44 has been approved by heycam

bors-servo · 2017-04-10T08:16:44Z

⌛ Testing commit 4a9ac44 with merge c33a98f...

Stylo: Add FFI interfaces for exposing style sources. https://bugzilla.mozilla.org/show_bug.cgi?id=1346256 https://reviewboard.mozilla.org/r/119044/  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16328)

bors-servo · 2017-04-10T08:28:51Z

💔 Test failed - linux-dev

emilio · 2017-04-10T08:29:52Z

./ports/geckolib/glue.rs:63: use statement is not in alphabetical order
	expected: style::gecko_bindings::structs::RawGeckoPresContextOwned
	found: style::gecko_bindings::structs::{RawServoStyleRule, ServoStyleSheet}

MozReview-Commit-ID: BlAb8sQ5WYl

bradwerth · 2017-04-10T08:44:52Z

@bors-servo r=heycam

bors-servo · 2017-04-10T08:44:53Z

📌 Commit bfc7e84 has been approved by heycam

bors-servo · 2017-04-10T09:04:56Z

⌛ Testing commit bfc7e84 with merge a0a60ba...

Stylo: Add FFI interfaces for exposing style sources. https://bugzilla.mozilla.org/show_bug.cgi?id=1346256 https://reviewboard.mozilla.org/r/119044/  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16328)

bors-servo · 2017-04-10T09:40:15Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing a0a60ba to master...

highfive assigned metajack Apr 10, 2017

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 10, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 10, 2017

highfive assigned heycam and unassigned metajack Apr 10, 2017

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 10, 2017

Manishearth reviewed Apr 10, 2017

View reviewed changes

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 10, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 10, 2017

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 10, 2017

Stylo: Add FFI interfaces for exposing style sources.

bfc7e84

MozReview-Commit-ID: BlAb8sQ5WYl

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 10, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 10, 2017

bors-servo merged commit bfc7e84 into servo:master Apr 10, 2017

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 10, 2017

bradwerth deleted the computedStyles branch April 10, 2017 09:43

Uh oh!

Comments

Conversation

bradwerth commented Apr 10, 2017 • edited by larsbergstrom Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

highfive commented Apr 10, 2017

Uh oh!

highfive commented Apr 10, 2017

Uh oh!

highfive commented Apr 10, 2017

Uh oh!

Manishearth commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

Manishearth commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

Manishearth commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

Manishearth Apr 10, 2017

Choose a reason for hiding this comment

Uh oh!

Manishearth commented Apr 10, 2017

Uh oh!

Manishearth Apr 10, 2017

Choose a reason for hiding this comment

Uh oh!

bradwerth commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

emilio commented Apr 10, 2017

Uh oh!

bradwerth commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

bors-servo commented Apr 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bradwerth commented Apr 10, 2017 •

edited by larsbergstrom

Loading