-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore: fix warnings for Windows-specific fonts code #37063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d04dd6 to
37a0983
Compare
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
37a0983 to
d04deb9
Compare
mrobinson
requested changes
May 21, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a few comments:
4b4bebc to
e3ee13b
Compare
mrobinson
approved these changes
May 21, 2025
Member
|
My suggestion was missing a |
Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
e3ee13b to
0d93d0c
Compare
0d93d0c to
41e1f60
Compare
Contributor
Author
|
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings from
components/fonts/platform/windows/font.rsandcomponents/fonts/platform/windows/font_list.rsdue to deprecations from dwrote.Testing: none, should behave as it did before