script: Wrap unsafe code in unsafe blocks for basic DOM types#37997
Merged
mrobinson merged 1 commit intoservo:mainfrom Jul 11, 2025
Merged
script: Wrap unsafe code in unsafe blocks for basic DOM types#37997mrobinson merged 1 commit intoservo:mainfrom
unsafe blocks for basic DOM types#37997mrobinson merged 1 commit intoservo:mainfrom
Conversation
There is a new default cargo clippy lint, `unsafe_op_in_unsafe_fn`, which requires unsafe code to be wrapped in unsafe blocks, even inside functions marked as unsafe. The lint is disabled as much of our code doesn't fulfill this contract. The thing itself is pretty useful in order to gradually remove unsafety, so this change starts adding `unsafe` blocks so we can eventually enable this lint. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
changed the title
unsafe blocksunsafe blocks for basic DOM types
jschwe
approved these changes
Jul 11, 2025
mrobinson
changed the title
unsafe blocks for basic DOM typesunsafe blocks for basic DOM types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new default cargo clippy lint,
unsafe_op_in_unsafe_fn,which requires unsafe code to be wrapped in unsafe blocks, even inside
functions marked as unsafe. The lint is disabled as much of our code
doesn't fulfill this contract. The thing itself is pretty useful in
order to gradually remove unsafety, so this change starts adding
unsafeblocks so we can eventually enable this lint.Testing: This doesn't change behavior so existings tests should suffice.
Fixes: This is part of #35955.