Add resource header for mime sniffing #39167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔨 Triggering try run (#17494303264) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17494303264): Flaky unexpected result (22)
Stable unexpected results that are known to be intermittent (35)
Stable unexpected results (30)
|
|
|
TimvdLippe
force-pushed
the
add-resource-header-for-mime-sniffing
branch
from
ad074e0 to
7de95e1
Compare
|
🔨 Triggering try run (#17495850559) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17495850559): Flaky unexpected result (30)
Stable unexpected results that are known to be intermittent (34)
Stable unexpected results (6)
|
|
|
|
These crashes puzzle me. For some reason the parser aborts prior to loading the document. Maybe I should not perform load document if that's the case? But how could that have worked before... |
TimvdLippe
force-pushed
the
add-resource-header-for-mime-sniffing
branch
from
7de95e1 to
631b8af
Compare
|
The crashes I figured out by adding another guard to the aborted flag. I also had to rearrange a bunch of stuff regarding CSP/policy container, since the reordering of loading exposed that we were processing these in the wrong way. Added relevant spec functions to make that possible. |
|
🔨 Triggering try run (#17513512174) for Linux (WPT) |
|
Test results for linux-wpt from try job (#17513512174): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (1)
|
|
|
jdm
approved these changes
Sep 6, 2025
jdm
added
the
S-needs-code-changes
TimvdLippe
force-pushed
the
add-resource-header-for-mime-sniffing
branch
from
631b8af to
9928a8b
Compare
The concept of a "resource header" is not well specced, since it is unclear what a "resource" is. That said, it most closely matches a "response" as part of the navigation params. With this change, we now delay loading the document until either two things happen: 1. We reached the end of the file 2. We processed 1445 bytes (as defined by spec) We initially store bytes in the resource header and then after loading parse the stored bytes. Any subsequent loading will process as before. Part of servo#14024 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
TimvdLippe
force-pushed
the
add-resource-header-for-mime-sniffing
branch
from
9928a8b to
7ba10aa
Compare
|
I made the |
TimvdLippe
removed
the
S-needs-code-changes
jdm
approved these changes
Sep 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Seems like a flaky infrastructure failure |
JasonHonKL
pushed a commit
to JasonHonKL/Pardus-Browser
that referenced
this pull request
Sep 8, 2025
The concept of a "resource header" is not well specced, since it is unclear what a "resource" is. That said, it most closely matches a "response" as part of the navigation params. With this change, we now delay loading the document until either two things happen: 1. We reached the end of the file 2. We processed 1445 bytes (as defined by spec) We initially store bytes in the resource header and then after loading parse the stored bytes. Any subsequent loading will process as before. Part of servo#14024 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com> Signed-off-by: JasonHonKL <j2004nol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept of a "resource header" is not well specced, since it is unclear what a "resource" is. That said, it most closely matches a "response" as part of the navigation params.
With this change, we now delay loading the document until either two things happen:
We initially store bytes in the resource header and then after loading parse the stored bytes. Any subsequent loading will process as before.
Part of #14024