canvas: Port CanvasMsg channel to generic channel #39348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve the warning message if the routed receiver disconnects and exit the thread. If the routed receiver disconnects, then we can't receive any canvas messages anymore, and any control messages can't remedy that, so we might as well exit. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
servo-highfive
added
the
S-awaiting-review
|
|
sagudev
approved these changes
Sep 17, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally also improve the warning message if the routed receiver disconnects and exit the thread.
If the routed receiver disconnects, we can't receive any canvas messages anymore, and any control messages can't remedy that, so we might as well exit.
Testing: Channel changes are covered by existing tests. Exiting the canvas thread if the routed thread disconnects is not tested, and needs reviewer attention.
Part of #38912