Skip to content

Conversation

@jdm
Copy link
Member

@jdm jdm commented Oct 20, 2025

This is the most basic integration possible. Current limitations include:

  • the done button doesn't trigger form submission/keyboard hiding
  • IME events don't trigger inputs (ie. pressing and holding a letter to get more options)

However, it is infinitely better than the current integration.

Testing: Manually tested in the Android emulator.
Fixes: #12127 (we can open more specific issues after this)

@jdm jdm requested a review from jschwe as a code owner October 20, 2025 07:20
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 20, 2025
@jdm
Copy link
Member Author

jdm commented Oct 20, 2025

FYI @nalladev

Copy link
Member

@mukilan mukilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 20, 2025
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
@jdm jdm force-pushed the android-keyboard branch from fea4f32 to ee4b1a4 Compare October 20, 2025 13:14
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 20, 2025
@jdm jdm enabled auto-merge October 20, 2025 13:15
@nalladev
Copy link

Will this be available in next nightly build

@jdm
Copy link
Member Author

jdm commented Oct 20, 2025

Will this be available in next nightly build

The one that will be released in 12-ish hours, I believe.

@jdm jdm added this pull request to the merge queue Oct 20, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 20, 2025
Merged via the queue into servo:main with commit 3a29c20 Oct 20, 2025
33 checks passed
@jdm jdm deleted the android-keyboard branch October 20, 2025 14:46
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 20, 2025
@jdm jdm restored the android-keyboard branch October 22, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android does not have keyboard support

4 participants