Skip to content

Conversation

@yerke
Copy link
Contributor

@yerke yerke commented Oct 25, 2025

add CanGc as argument to structuredclone::read

Testing: These changes do not require tests because they are a refactor.
Closes #40154

Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
@yerke yerke requested a review from gterzian as a code owner October 25, 2025 07:42
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 25, 2025
@yerke
Copy link
Contributor Author

yerke commented Oct 25, 2025

@jdm Is this what you had in mind for #40154?

Copy link
Member

@jdm jdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Oct 25, 2025
@jdm jdm enabled auto-merge October 25, 2025 08:01
@jdm jdm added this pull request to the merge queue Oct 25, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2025
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Oct 25, 2025
@jschwe jschwe added this pull request to the merge queue Oct 25, 2025
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Oct 25, 2025
Merged via the queue into servo:main with commit aced942 Oct 25, 2025
39 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 25, 2025
@yerke yerke deleted the replace-remaining-CanGc-note-part-17 branch October 25, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

structuredclone::read need a CanGc argument

4 participants