layout: Show pointer cursor for submit input with text value #40205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servo-highfive
added
the
S-awaiting-review
Member
|
Just to confirm: does the text cursor still appear for a normal text input? Does our behaviour match other browsers? |
Contributor
Author
|
Yes, it does, as far as I could tell from my manual testing. |
jdm
approved these changes
Oct 27, 2025
servo-highfive
added
S-awaiting-review
mrobinson
requested changes
Oct 27, 2025
Comment on lines
155
to
156
| overflow: hidden !important; | ||
| white-space: pre; |
Member
There was a problem hiding this comment.
Why are you removing overflow: hidden and white-space: pre here? Isn't it sufficient to simply remove cursor: text and to make the new rule?
cc @Loirooriol
Contributor
Author
There was a problem hiding this comment.
I returned the old block and added a new one. Now WPT tests pass, and the behavior is still the same in the PR description.
servo-highfive
added
S-needs-code-changes
Member
|
Looks like a good fix, but I want to double-check the removal of these two unrelated CSS rules before landing. |
Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
servo-highfive
added
S-awaiting-review
mrobinson
approved these changes
Nov 1, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
layout: Show pointer cursor for submit input with text value
Before:
After:
Testing: tested manually, as suggested by @jdm.
Fixes: #9084