Script: Efficient DOMString methods for as_bytes, eq_ascii, is_ascii, to_jsval #40283
+135
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servo-highfive
added
the
S-awaiting-review
jdm
requested changes
Oct 30, 2025
servo-highfive
added
S-needs-code-changes
to_jsval for DOMString based on the bytes. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Narfinger
force-pushed
the
lazydomstring-improvements4
branch
from
23f9143 to
02f5fa2
Compare
servo-highfive
added
S-awaiting-review
Contributor
Author
|
It seems that eq_ascii was not necessary anymore so I removed it completely. The PartialEq was already doing a fast compare if it was ascii. |
jdm
approved these changes
Nov 3, 2025
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Narfinger
force-pushed
the
lazydomstring-improvements4
branch
from
02f5fa2 to
3cfb021
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements efficient methods for as_bytes, eq_ascii, is_ascii and to_jsval.
Tests were added for as_bytes. Additionally, BytesView now has an internal type to make sure nobody can construct it.
Testing: New unit tests were added and some old ones covered the new functions.