script: Implement derive bits operation of ECDH #40333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servo-highfive
added
the
S-awaiting-review
arihant2math
approved these changes
Nov 3, 2025
servo-highfive
removed
the
S-awaiting-review
arihant2math
added
the
S-awaiting-review
arihant2math
reviewed
Nov 3, 2025
| let secret_length = secret.len(); | ||
| secret[secret_length - 1] &= mask; | ||
| } | ||
| Ok(secret[..length.div_ceil(8) as usize].to_vec()) |
Contributor
There was a problem hiding this comment.
nit: This be de-duplicated from the previous occurrence.
Member
Author
There was a problem hiding this comment.
Nice catch. The resizing of secret at L267 is redundant since it has been done before.
jdm
approved these changes
Nov 4, 2025
Member
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
This looks fine, but I'd like to understand the remaining test failure.
| [P-521 mismatched curves] | ||
| expected: FAIL | ||
|
|
||
| [P-521 public property of algorithm is not an ECDSA public key] |
Member
Author
There was a problem hiding this comment.
This test tries to derive a key with an ECDSA public key rather than an ECDH public key, and expects step 4 throw an InvalidAccessError. However, we have not yet implemented key import operation of ECDSA, so this test cannot reach step 4 to get an InvalidAccessError.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
kkoyung
force-pushed
the
ecdh-derive-bits
branch
from
16ca840 to
bf76e79
Compare
servo-highfive
added
S-awaiting-review
Member
Author
|
I rebased on the main branch, and added the CanGc argument introduced in recent PR #40404 |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish adding ECDH support to WebCrypto API. This patch implements derive bits operation of ECDH.
Testing: Pass some WPT tests that were expected to fail.
Fixes: Part of #39060