Reduce unnecessary type conversion and share WebDriverCommandMsg::LoadUrl handler across platform
#40393
+27
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
servo-highfive
added
the
S-awaiting-review
|
🔨 Triggering try run (#19058561405) for OpenHarmony |
|
✨ Try run (#19058561405) succeeded. |
yezhizhen
commented
Nov 4, 2025
Comment on lines
-619
to
-620
| self.inner_mut().focused_webview_id = Some(webview_id); | ||
| webview.focus(); |
Member
Author
There was a problem hiding this comment.
These were quite messy and wrong. We should've never set focused_webview_id by ourself after calling focus method. We relies on IPC feedback for it.
jdm
approved these changes
Nov 4, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServoUrl,Url, string sliceWebDriverCommandMsg::LoadUrlhandler across platformTesting: Covered by existing test. Manually tested for OHOS.