Skip to content

Conversation

@kkoyung
Copy link
Member

@kkoyung kkoyung commented Nov 4, 2025

Start adding X25519 support to WebCrypto API. This patch implements import key operation of X25519, using X25519 implementation from the crate x25519-dalek.

Testing:

  • Pass some WPT tests that were expected to fail.
  • Some FAIL expectations are added. They require other not-yet-implemented operations of X25519. WPT skipped them when "import key" operation for X25519 were not yet implemented.

Fixes: Part of #39060

Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@kkoyung kkoyung requested a review from gterzian as a code owner November 4, 2025 10:19
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 4, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 4, 2025
@jdm jdm added this pull request to the merge queue Nov 4, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 4, 2025
Merged via the queue into servo:main with commit 84869a2 Nov 4, 2025
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 4, 2025
@kkoyung kkoyung deleted the x25519-import branch November 5, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants