WebGLBuffer: follow spec for buffer binding restrictions #40462

Taym95 · 2025-11-06T15:27:55Z

WebGLBuffer: follow spec for buffer binding restrictions

Testing: more WebGLBuffer pass

components/script/dom/webgl/webglbuffer.rs

github-actions · 2025-11-06T22:58:46Z

🔨 Triggering try run (#19152403662) for Linux (WPT)

github-actions · 2025-11-06T23:25:33Z

Test results for linux-wpt from try job (#19152403662):

Flaky unexpected result (42)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```

OK /_mozilla/mozilla/FileAPI/file-upload.html (#40348)

FAIL [expected PASS] subtest: form submission of uploaded file

assert_equals: expected "OK" but got "\n\n\n\n\n    var fileInput = document.getElementById(\"file-input\");\n    fileInput.addEventListener(\"change\", () =&gt; {\n      parent.postMessage(\"loadedAndFilesChanged\");\n    });\n    fileInput.selectFiles([\"./tests/wpt/mozilla/tests/mozilla/FileAPI/resource/upload.txt\"]);\n\n"

CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
OK /_mozilla/webxr/create_session.https.html
- FAIL [expected PASS] subtest: create_session
```
can't access property "simulateDeviceConnection", navigator.xr.test is undefined
```

OK /_mozilla/webxr/obtain_frame.https.html

FAIL [expected PASS] subtest: obtain_frame

promise_test: Unhandled rejection with value: object "TypeError: can't access property "simulateDeviceConnection", navigator.xr.test is undefined"

ERROR [expected OK] /_webgl/conformance/attribs/gl-bindAttribLocation-matrix.html
CRASH [expected OK] /_webgl/conformance/canvas/buffer-offscreen-test.html
CRASH [expected OK] /_webgl/conformance/glsl/misc/shader-with-ivec4-return-value.frag.html
CRASH [expected OK] /_webgl/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006.html
CRASH [expected OK] /_webgl/conformance/ogles/GL/log/log_009_to_012.html
CRASH [expected OK] /_webgl/conformance/ogles/GL/struct/struct_001_to_008.html
CRASH [expected OK] /_webgl/conformance/ogles/GL/vec3/vec3_001_to_008.html
CRASH [expected ERROR] /_webgl/conformance/rendering/clear-default-framebuffer-with-scissor-test.html
CRASH [expected OK] /_webgl/conformance/rendering/point-specific-shader-variables.html
CRASH [expected OK] /_webgl/conformance/textures/image/tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html
CRASH [expected OK] /_webgl/conformance/textures/image/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html
CRASH [expected OK] /_webgl/conformance/textures/image_bitmap_from_image_bitmap/tex-2d-alpha-alpha-unsigned_byte.html
TIMEOUT /content-security-policy/inheritance/location-reload.html (#38983)
- FAIL [expected PASS] subtest: location.reload() of empty iframe.
```
assert_equals: Image should be blocked by CSP after reload. expected "img blocked" but got "img loaded"
```
OK /cookiestore/cookieStore_getAll_set_creation_url.https.any.html
- FAIL [expected PASS] subtest: cookieStore.set and cookieStore.getAll use the creation url
```
assert_equals: expected 1 but got 2
```

OK [expected TIMEOUT] /cookiestore/httponly_cookies.https.window.html

FAIL [expected TIMEOUT] subtest: HttpOnly cookies are not observed

assert_equals: HttpOnly cookie we wrote using HTTP in cookie jar is invisible to script expected (undefined) undefined but got (string) "cspViolationReportCookie1=1"

FAIL [expected NOTRUN] subtest: HttpOnly cookies can not be set by document.cookie

assert_equals: Trying to store an HttpOnly cookie with document.cookie fails expected "cookie1=value1; cookie3=value3" but got "HTTPONLY-cookie=value; cookie1=value1; cookie3=value3"

FAIL [expected NOTRUN] subtest: HttpOnly cookies can not be set by CookieStore

assert_equals: httpOnly is not an option for CookieStore.set() expected "cookie1=value1; cookie2=value2; cookie3=value3" but got "HTTPONLY-cookie=value; cookie1=value1; cookie2=value2; cookie3=value3"

FAIL [expected NOTRUN] subtest: HttpOnly cookies are not deleted/overwritten

assert_equals: HttpOnly cookie is not deleted expected (string) "HTTPONLY-cookie=value" but got (undefined) undefined

CRASH [expected OK] /cookiestore/idlharness.https.any.worker.html
FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
CRASH [expected OK] /css/css-sizing/button-min-width.html
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Null value should submit nothing
- PASS [expected FAIL] subtest: setFormValue with an empty FormData should submit nothing
- PASS [expected FAIL] subtest: Newline normalization - \r\n in name (urlencoded)
OK [expected TIMEOUT] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- PASS [expected TIMEOUT] subtest: [keepalive][iframe][load] mixed content redirect; setting up
OK /fetch/fetch-later/new-window.https.window.html (#32036)
- FAIL [expected PASS] subtest: A same-origin window[target=''][features=''] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target=''][features='popup'] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target='_blank'][features=''] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
- FAIL [expected PASS] subtest: A same-origin window[target='_blank'][features='popup'] can trigger fetchLater.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
OK /fetch/fetch-later/permissions-policy/deferred-fetch-allowed-by-permissions-policy.https.window.html
- FAIL [expected PASS] subtest: Permissions policy header: "deferred-fetch=*" allows fetchLater() in the top-level document.
```
assert_equals: Number of sent beacons does not match expected count: expected 1 but got 0
```
TIMEOUT /html/browsers/history/the-history-interface/001.html (#12580)
- FAIL [expected PASS] subtest: traversing history must also traverse hash changes
```
assert_equals: (this could cause other failures later on) expected "" but got "test"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted

OK /html/dom/documents/resource-metadata-management/document-cookie.html

FAIL [expected PASS] subtest: document has no cookie

assert_equals: expected "" but got "domain-attribute-matches-host=0"

FAIL [expected PASS] subtest: document.cookie

assert_equals: expected "" but got "domain-attribute-matches-host=0"

FAIL [expected PASS] subtest: document.cookie 1

assert_equals: expected "a=b" but got "a=b; domain-attribute-matches-host=0"

CRASH [expected OK] /html/dom/render-blocking/element-render-blocking-020.html
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- TIMEOUT [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
ERROR [expected OK] /html/semantics/embedded-content/media-elements/event_timeupdate_noautoplay.html (#25046)
OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-location-replace-set-src.html (#32697)
- PASS [expected FAIL] subtest: Navigating iframe loading='lazy' and then setting src: location.replace
CRASH [expected TIMEOUT] /pointerevents/mouse-pointer-boundary-events-for-shadowdom.html
ERROR [expected OK] /resource-timing/cors-preflight.any.html (#28694)
CRASH [expected OK] /trusted-types/block-string-assignment-to-DOMParser-parseFromString.html
CRASH [expected OK] /trusted-types/eval-function-constructor.html
CRASH [expected OK] /trusted-types/get-trusted-types-compliant-attribute-value.html
CRASH [expected TIMEOUT] /wasm/webapi/invalid-code.any.worker.html
ERROR [expected OK] /workers/baseurl/alpha/sharedworker-in-worker.html (#21315)

Stable unexpected results that are known to be intermittent (34)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /_mozilla/mozilla/getBoundingClientRect.html (#39668)
- FAIL [expected PASS] subtest: getBoundingClientRect 1
```
assert_equals: expected 62 but got 60.35
```
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- FAIL [expected PASS] subtest: Delete layer invalidates @font-face
```
assert_equals: expected "220px" but got "133px"
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 2
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
```
assert_equals: quoted system-ui matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
```
assert_equals: quoted generic(kai) matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted ui-sans-serif (drawing text in a canvas)
```
assert_equals: unquoted ui-sans-serif does not match @font-face rule expected 40 but got 125
```
OK /custom-elements/form-associated/form-disabled-callback.html (#38843)
- PASS [expected FAIL] subtest: A disabled form-associated custom element should not submit an entry for it
FAIL [expected TIMEOUT] /dom/xslt/large-cdata.html (#38029)
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
OK /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-Site -> Same Origin, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-Site -> Cross-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Origin -> Cross-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Site -> Same-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - attributes: crossorigin=anonymous
- PASS [expected FAIL] subtest: sec-fetch-dest - no attributes
OK /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy same-origin destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-dest - Not sent to non-trustworthy same-origin destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-dest - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-user - Not sent to non-trustworthy same-origin destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-user - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - HTTPS downgrade-upgrade, no attributes
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- FAIL [expected PASS] subtest: Link with onclick form submit to javascript url and href navigation
```
assert_equals: expected "href" but got "click"
```

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-nonexistent.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with non-existent fragments should work.
```
Test timed out
```
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/src_object_blob.html (#40340)
- TIMEOUT [expected PASS] subtest: HTMLMediaElement.srcObject blob
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: Basic test (normal form)
- PASS [expected FAIL] subtest: multipart/form-data: Basic test (formdata event)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in value (normal form)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- PASS [expected FAIL] subtest: text/plain: Basic test (normal form)
- PASS [expected FAIL] subtest: text/plain: Basic File test (normal form)
- PASS [expected FAIL] subtest: text/plain: 0x00 in filename (formdata event)
- PASS [expected FAIL] subtest: text/plain: double quote in filename (formdata event)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic test (normal form)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic test (formdata event)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: Basic File test (normal form)
OK /html/semantics/forms/historical.html (#28568)
- PASS [expected FAIL] subtest: <input name=isindex> should not be supported
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /preload/preload-error.sub.html (#37177)
- PASS [expected FAIL] subtest: 404 (fetch): main
- PASS [expected FAIL] subtest: CORS (fetch): main
OK /preload/preload-xhr.html (#39092)
- FAIL [expected PASS] subtest: Make an XHR request immediately after creating link rel=preload.
```
assert_equals: resources/dummy.xml?token=e2ad42dd-53b7-486d-8e55-b4aa857fc582 expected 1 but got 0
```
OK /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- FAIL [expected PASS] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```

Stable unexpected results (2)

ERROR [expected OK] /_webgl/conformance2/context/context-resize-changes-buffer-binding-bug.html
- FAIL [expected PASS] subtest: WebGL test #1
```
assert_true: successfullyParsed should be true (of type boolean). Was undefined (of type undefined). expected true got false
```
CRASH [expected OK] /mimesniff/sniffing/html.window.html

github-actions · 2025-11-06T23:25:41Z

⚠️ Try run (#19152403662) failed.

Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>

Taym95 requested a review from gterzian as a code owner November 6, 2025 15:27

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 6, 2025

jdm approved these changes Nov 6, 2025

View reviewed changes

components/script/dom/webgl/webglbuffer.rs Outdated Show resolved Hide resolved

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 6, 2025

Taym95 enabled auto-merge November 6, 2025 21:53

Taym95 added this pull request to the merge queue Nov 6, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 6, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2025

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 6, 2025

Taym95 added the T-linux-wpt Do a try run of the WPT label Nov 6, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Nov 6, 2025

WebGLBuffer: follow spec for buffer binding restrictions

0561e4f

Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>

Taym95 force-pushed the webglbuffer-follow-spec-buffer-binding-restrictions branch from eff37c8 to 0561e4f Compare November 6, 2025 23:33

servo-highfive removed the S-tests-failed The changes caused existing tests to fail. label Nov 6, 2025

Taym95 enabled auto-merge November 6, 2025 23:33

Taym95 added this pull request to the merge queue Nov 6, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 6, 2025

Merged via the queue into servo:main with commit d8d3d37 Nov 7, 2025
32 checks passed

Taym95 deleted the webglbuffer-follow-spec-buffer-binding-restrictions branch November 7, 2025 00:17

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

WebGLBuffer: follow spec for buffer binding restrictions #40462

WebGLBuffer: follow spec for buffer binding restrictions #40462

Taym95 commented Nov 6, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

WebGLBuffer: follow spec for buffer binding restrictions #40462

WebGLBuffer: follow spec for buffer binding restrictions #40462

Conversation

Taym95 commented Nov 6, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants