Fix warnings in unit tests (#41524)#41529
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Dec 27, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
…nly symbols and remove stray semicolon in webview test. Fixes servo#41524 Signed-off-by: Eyad3skr <eyad.abdulaal@student.giu-uni.de>
Eyad3skr
force-pushed
the
fix/41524-test-warnings
branch
from
6b95d06 to
a0c2024
Compare
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix warnings when building unit tests by adding #[allow(dead_code)] attributes to evaluate_javascript function and WebViewDelegateImpl::reset method in common/mod.rs (which are used in some test binaries but not others), and removing the unnecessary trailing semicolon after the struct definition in webview.rs test_user_content_manager_for_auxiliary_webviews test. Fixes #41524