devtools: Correctly cache console messages#41895
Merged
mrobinson merged 3 commits intoservo:mainfrom Jan 15, 2026
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
Signed-off-by: eri <eri@igalia.com>
mrobinson
requested changes
Jan 14, 2026
servo-highfive
added
S-needs-code-changes
Signed-off-by: eri <eri@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
servo-highfive
added
S-awaiting-review
mrobinson
approved these changes
Jan 15, 2026
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Thanks for the explanation!
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: eri <eri@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Jan 15, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix caching before the console is opened and stop sending messages prematurely.
Fix line numbers not showing in console messages because of a missing
rename_all.Remove
getCachedMessagesin favour of sending a list of messages as a reply to thewatchResourcesforconsole-message/error-messagein the watcher.Remove
startListenersandstopListeners. These are legacy methods of watching properties before the watcher actor. It is preferred to enable properties insupported_resourcesin the watcher than to use these messages.Remove
clearMessagesCache, onlyclearMessagesCacheAsyncseems to be used now. Add a reply toclearMessagesCacheAsync.Simplify a bit the structs for console messages and prefer serde's annotations to manual serialization. Merge
handle_console_messageandhandle_page_error, and improve the usability ofConsoleResource.Fix some fields in console messages. We are missing
source_idfor now. This will be easier to add after better support for source actors. We are also missing stack traces.Testing: Manual testing
Fixes: #26666