Skip to content

script: Do not adjust the edit point in text fields when non-primary buttons are pressed#41974

Merged
mrobinson merged 1 commit intoservo:mainfrom
mrobinson:no-right-click-edit-point
Jan 17, 2026
Merged

script: Do not adjust the edit point in text fields when non-primary buttons are pressed#41974
mrobinson merged 1 commit intoservo:mainfrom
mrobinson:no-right-click-edit-point

Conversation

@mrobinson
Copy link
Copy Markdown
Member

We should not move the text cursor or change the text selection when
non-primary (such as the right) mouse buttons are pressed. Doing so
interferes with the common operations:

  1. Select text
  2. Open context menu
  3. Copy text

This change fixes that.

Testing: New WPT-style tests are added.

@mrobinson mrobinson requested a review from gterzian as a code owner January 17, 2026 09:33
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 17, 2026
…buttons are pressed

We should not move the text cursor or change the text selection when
non-primary (such as the right) mouse buttons are pressed. Doing so
interferes with the common operations:

1. Select text
2. Open context menu
3. Copy text

This change fixes that.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
@mrobinson mrobinson force-pushed the no-right-click-edit-point branch from e75e106 to 23d33d3 Compare January 17, 2026 12:26
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 17, 2026
@mrobinson mrobinson added this pull request to the merge queue Jan 17, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 17, 2026
Merged via the queue into servo:main with commit 37cef42 Jan 17, 2026
29 checks passed
@mrobinson mrobinson deleted the no-right-click-edit-point branch January 17, 2026 14:04
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants