script: Do not consider a node an ancestor of itself in Node::is_ancestor_of#42263
Merged
mrobinson merged 1 commit intoservo:mainfrom Jan 31, 2026
Merged
script: Do not consider a node an ancestor of itself in Node::is_ancestor_of#42263mrobinson merged 1 commit intoservo:mainfrom
Node::is_ancestor_of#42263mrobinson merged 1 commit intoservo:mainfrom
Conversation
…estor_of` This change fixes a crash in options collections due to the fact that a `<select>` element was being considered an ancestor of itself. This regression likely introduced in servo#40776. This change also fills in the specification text for `HTMLOptionCollect::Add`. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
servo-highfive
added
the
S-awaiting-review
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57466) with upstreamable changes. |
yezhizhen
approved these changes
Jan 31, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Member
Author
|
I neglected to mention in the PR description that I audited the other callers of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a crash in options collections due to the fact that a
<select>element was being considered an ancestor of itself. Thisregression likely introduced in #40776.
This change also fills in the specification text for
HTMLOptionCollect::Add.Testing: This change adds a WPT crash test.
Fixes: #41080.