script: Allow any valid CSS color for color input values by simonwuelker · Pull Request #42275 · servo/servo

simonwuelker · 2026-02-01T17:18:53Z

Testing: New tests start to pass
Closes: #42117

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

github-actions · 2026-02-01T17:29:01Z

🔨 Triggering try run (#21567142498) for Linux (WPT)

github-actions · 2026-02-01T17:57:38Z

Test results for linux-wpt from try job (#21567142498):

Flaky unexpected result (27)

OK /FileAPI/file/send-file-form-controls.html

FAIL [expected PASS] subtest: Upload file-for-upload-in-form-BS-[�].txt (ASCII) in UTF-8 form

assert_greater_than: file-for-upload-in-form-BS-[�].txt: multipart form data must have at least 3 lines: "" expected a number greater than 2 but got 0

FAIL [expected PASS] subtest: Upload file-for-upload-in-form-VT-[�].txt (ASCII) in UTF-8 form

assert_greater_than: file-for-upload-in-form-VT-[�].txt: multipart form data must have at least 3 lines: "" expected a number greater than 2 but got 0

OK /FileAPI/file/send-file-form-utf-8.html

FAIL [expected PASS] subtest: Upload file-for-upload-in-form-.txt (x-user-defined) in UTF-8 form

assert_greater_than: file-for-upload-in-form-.txt: multipart form data must have at least 3 lines: "" expected a number greater than 2 but got 0

FAIL [expected PASS] subtest: Upload file-for-upload-in-form-â˜ºðŸ˜‚.txt (windows-1252) in UTF-8 form

assert_greater_than: file-for-upload-in-form-â˜ºðŸ˜‚.txt: multipart form data must have at least 3 lines: "" expected a number greater than 2 but got 0

OK /IndexedDB/idbfactory-databases-opaque-origin.html
- FAIL [expected PASS] subtest: IDBFactory.databases() in non-sandboxed iframe should not reject
```
assert_equals: IDBFactory.databases() should not reject expected "no exception" but got "OperationError"
```
OK /IndexedDB/idbfactory-open-error-properties.any.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
OK /IndexedDB/idbfactory-open-error-properties.any.worker.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
TIMEOUT [expected PASS] /css/CSS2/generated-content/content-004.xht
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- PASS [expected FAIL] subtest: Delete layer invalidates @font-face
CRASH [expected PASS] /css/css-overflow/scroll-marker-in-display-none-column-crash.html
OK /css/cssom-view/offsetTopLeft-border-box.html (#40826)
- PASS [expected FAIL] subtest: container: 0
- PASS [expected FAIL] subtest: container: 1
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - empty name exists
- PASS [expected FAIL] subtest: Newline normalization - \r\n in value (urlencoded)
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

PASS [expected TIMEOUT] subtest: Non-HTMLElement should not support autofocus

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;input autofocus=""&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

promise_test: Unhandled rejection with value: object "TypeError: can't access property "appendChild", w.document.querySelector(...) is null"

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-location-assign.html (#32863)

FAIL [expected PASS] subtest: Navigating iframe loading='lazy' before it is loaded: location.assign

uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?nav" but got "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src"

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-location-replace.html (#32604)

FAIL [expected PASS] subtest: Navigating iframe loading='lazy' before it is loaded: location.replace

uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?nav" but got "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src"

TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: Basic File test (normal form)
```
assert_equals: expected "\r\nContent-Disposition: form-data; name=\"basic\"; filename=\"file-test.txt\"\r\nContent-Type: text/plain\r\n\r\n\r\n--\r\n" but got ""
```
- PASS [expected FAIL] subtest: multipart/form-data: Basic File test (formdata event)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic test (formdata event)
```
assert_equals: expected "basic=test\r\n" but got ""
```
- FAIL [expected PASS] subtest: text/plain: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt\r\n" but got ""
```
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic test (formdata event)
```
assert_equals: expected "basic=test" but got ""
```
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: double quote in value (formdata event)
OK /service-workers/service-worker/fetch-event.https.html (#36234)
- PASS [expected FAIL] subtest: Service Worker falls back to network in fetch event with POST form
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- TIMEOUT [expected PASS] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
OK /wasm/webapi/abort.any.worker.html (#40013)
- FAIL [expected PASS] subtest: instantiateStreaming() asynchronously racing with abort should succeed or reject with AbortError
```
assert_equals: expected "AbortError" but got "CompileError"
```
CRASH [expected OK] /websockets/unload-a-document/003.html
CRASH [expected OK] /workers/WorkerGlobalScope_setInterval.htm

Stable unexpected results that are known to be intermittent (30)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbrequest-onupgradeneeded.any.html (#38895)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess
OK /IndexedDB/idbrequest-onupgradeneeded.any.worker.html (#38971)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/transaction-deactivation-timing.any.html (#38772)
- PASS [expected FAIL] subtest: New transactions are deactivated before next task
- PASS [expected FAIL] subtest: New transactions from microtask are deactivated before next task
OK /_mozilla/css/offset_properties_inline.html (#40543)
- PASS [expected FAIL] subtest: offsetTop
- PASS [expected FAIL] subtest: offsetLeft
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /beacon/beacon-basic.https.window.html (#41723)
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = string
```
assert_false: expected false got true
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- FAIL [expected PASS] subtest: @font-face override update with appended sheet 2
```
assert_equals: expected "80px" but got "38.3166666666667px"
```
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 40 but got 125
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted sans-serif (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted math (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
- And 5 more unexpected results...
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-user
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- FAIL [expected PASS] subtest: content sec-fetch-site - HTTPS downgrade-upgrade
```
assert_unreached: Reached unreachable code
```
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-disabled-by-feature-policy.https.sub.html (#41221)
- TIMEOUT [expected FAIL] subtest: Feature-Policy header: autoplay "none" disallows same-origin iframes.
```
Test timed out
```
OK [expected ERROR] /html/user-activation/no-activation-thru-escape-key.html (#40343)
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
- PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK /resource-timing/test_resource_timing.html (#25720)
- PASS [expected NOTRUN] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
OK /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 9.39 but got 9.38
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /visual-viewport/resize-event-order.html (#41981)
- PASS [expected FAIL] subtest: Popup: DOMWindow resize fired before VisualViewport.

github-actions · 2026-02-01T17:57:44Z

✨ Try run (#21567142498) succeeded.

components/script/dom/html/htmlinputelement.rs

TimvdLippe · 2026-02-01T19:43:17Z

tests/wpt/meta/html/semantics/forms/the-input-element/color.window.js.ini

-  [Testing '#fff' with color space 'limited-srgb' and  without alpha (setAttribute("value"))]
-    expected: FAIL
-
  [Testing '#fff' with color space 'limited-srgb' and  without alpha (value)]


What's the reason that the previous test is now passing, but these ones aren't?

they use the limited-srgb colorspace (or other non-default ones), and we don't support the colorspace attribute yet, so these get serialized incorrectly.

What I said is wrong, limited-srgb is the default. But we don't implement other things that this test needs, like the colorSpace IDL attribute on HTMLInputElement. I'll fix these in a followup.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

simonwuelker requested a review from gterzian as a code owner February 1, 2026 17:18

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2026

script: Allow any valid CSS color for color input values

0321850

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

simonwuelker force-pushed the css-color-inputs branch from d1bb493 to 0321850 Compare February 1, 2026 17:26

simonwuelker added the T-linux-wpt Do a try run of the WPT label Feb 1, 2026

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Feb 1, 2026

TimvdLippe approved these changes Feb 1, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2026

Address review comments

084a36e

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2026

simonwuelker enabled auto-merge February 1, 2026 19:52

simonwuelker added this pull request to the merge queue Feb 1, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 1, 2026

Merged via the queue into servo:main with commit 2204bb2 Feb 1, 2026
32 checks passed

simonwuelker deleted the css-color-inputs branch February 1, 2026 20:59

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: Allow any valid CSS color for color input values#42275

script: Allow any valid CSS color for color input values#42275
simonwuelker merged 2 commits intoservo:mainfrom
simonwuelker:css-color-inputs

simonwuelker commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

Uh oh!

Uh oh!

TimvdLippe Feb 1, 2026

Uh oh!

simonwuelker Feb 1, 2026 •

edited

Loading

Uh oh!

simonwuelker Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

simonwuelker commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

Uh oh!

Uh oh!

TimvdLippe Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

simonwuelker Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simonwuelker Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

simonwuelker Feb 1, 2026 •

edited

Loading