devtools: Handle disconnected error gracefully when shutting down servo#42543
Merged
simonwuelker merged 1 commit intoservo:mainfrom Feb 11, 2026
Merged
devtools: Handle disconnected error gracefully when shutting down servo#42543simonwuelker merged 1 commit intoservo:mainfrom
simonwuelker merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
simonwuelker
force-pushed
the
devtools-shutdown
branch
from
5281348 to
ab2e155
Compare
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the servo window is closed while there is an active devtools connection then the devtools threads reliably panics because it can't talk to script anymore. We can simply ignore the
Disconnectederror when shutting down. If the script thread already shut down then there's nothing meaningful for the devtools to send anyways.Testing: This kind of interaction is hard to test. I've not written an automated test.