script: Implement check for supported and enabled commands#42634
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Feb 17, 2026
Merged
script: Implement check for supported and enabled commands#42634TimvdLippe merged 1 commit intoservo:mainfrom
TimvdLippe merged 1 commit intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#22036341222) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22036341222): Flaky unexpected result (33)
Stable unexpected results that are known to be intermittent (15)
Stable unexpected results (31)
|
|
|
TimvdLippe
force-pushed
the
exec-command-support
branch
from
1e2108f to
c304b32
Compare
The first step of `execCommand` commands is to figure out if they are supported and enabled. Therefore, implement these two pieces with only 1 command: delete. The implementation of `delete` is currently mostly dummy, to have at least something going. But the main part of this change is to setup the infrastructure to figure out when commands are supported and enabled. For the first part, its simply the list of commands we currently have implemented, which is only delete. For the second part, we need to consider the active range of the current selection and do various checks, as well as check the presence of `contenteditable`. Part of servo#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
TimvdLippe
force-pushed
the
exec-command-support
branch
from
c304b32 to
8d216cf
Compare
servo-highfive
added
the
S-awaiting-review
simonwuelker
approved these changes
Feb 17, 2026
Member
simonwuelker
left a comment
simonwuelker
left a comment
There was a problem hiding this comment.
Personally I'd prefer a Command enum that we can match in fn execute and friends over Box<dyn BaseCommand>. In my experience the latter is hard to debug because its annoying to identify the command given only dyn BaseCommand. But I'm not working on this code, so I'll leave that up to you.
Thanks for working on this API!
servo-highfive
removed
the
S-awaiting-review
Contributor
Author
|
I did think about an enum and am not yet sure what's gonna work best. The spec is quite vague at times and all over the place, so I am trying my best to put some structure to it. Once I know more details, I will reconsider implementing it as enum for the mentioned reasons. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first step of
execCommandcommands is to figure outif they are supported and enabled. Therefore, implement
these two pieces with only 1 command: delete.
The implementation of
deleteis currently mostly dummy,to have at least something going. But the main part of
this change is to setup the infrastructure to figure out
when commands are supported and enabled.
For the first part, its simply the list of commands we
currently have implemented, which is only delete.
For the second part, we need to consider the active range
of the current selection and do various checks, as well as
check the presence of
contenteditable.Part of #25005