script: Introduce reflect_dom_object_with_proto_and_cx and use it in 2d canvas#42699
Merged
TimvdLippe merged 2 commits intoservo:mainfrom Feb 18, 2026
Merged
script: Introduce reflect_dom_object_with_proto_and_cx and use it in 2d canvas#42699TimvdLippe merged 2 commits intoservo:mainfrom
reflect_dom_object_with_proto_and_cx and use it in 2d canvas#42699TimvdLippe merged 2 commits intoservo:mainfrom
Conversation
…n 2d canvas Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
servo-highfive
added
the
S-awaiting-review
TimvdLippe
approved these changes
Feb 18, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
LGTM, but if most usages won't have the proto, I think it's better to make a version without it as well. So that we won't have all those None everywhere.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
Just to complement existing with_proto method introduced in #42699. Justification for arg ordering: reflect_dom_* have arguments reversed, so first one is Box (the most important) then global, proto and lastly cx. --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
simonwuelker
pushed a commit
to simonwuelker/servo
that referenced
this pull request
Feb 23, 2026
Just to complement existing with_proto method introduced in servo#42699. Justification for arg ordering: reflect_dom_* have arguments reversed, so first one is Box (the most important) then global, proto and lastly cx. --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: Should be covered by WPT tests.
Part of #40600