script: Do not unnecessary clone CSP list in Document::get_csp_list#42716
Merged
TimvdLippe merged 2 commits intoservo:mainfrom Feb 23, 2026
Merged
script: Do not unnecessary clone CSP list in Document::get_csp_list#42716TimvdLippe merged 2 commits intoservo:mainfrom
Document::get_csp_list#42716TimvdLippe merged 2 commits intoservo:mainfrom
Conversation
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
servo-highfive
added
the
S-awaiting-review
mrobinson
changed the title
Document::get_csp_list
servo-highfive
removed
the
S-awaiting-review
TimvdLippe
approved these changes
Feb 19, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Note that document.get_csp_list is similar to globalscope.get_csp_list. Is the same optimization applicable there?
Contributor
Author
|
I am not sure to be honest. I will look at it tomorrow but I didn't want to figure out where the process/threads bounds in it where. |
servo-highfive
added
the
S-awaiting-review
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Contributor
Author
|
So update on globalscope.get_csp_list. Most of them are copied into structures so it doesn't make much sense to change this. |
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously clonsed the CSP list unnecessarily which consisted of roughly 2.7%. 1.2% spend in Document::get_csp_list.
We can easily avoid it with Ref and cloning it deliberately when needed.
Testing: This is functionally identical to the previous code as it is a change from clone to a Ref<>.