layout: Extend damage propagation isolation to table cells and captions#42717
Merged
mrobinson merged 1 commit intoservo:mainfrom Feb 23, 2026
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
|
🔨 Triggering try run (#22190432826) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22190432826): Flaky unexpected result (23)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (2)
|
|
|
mrobinson
force-pushed
the
extend-box-tree-damage-isolation-to-tables
branch
from
fa9c48f to
365651d
Compare
|
🔨 Triggering try run (#22194524592) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22194524592): Flaky unexpected result (39)
Stable unexpected results that are known to be intermittent (20)
|
|
✨ Try run (#22194524592) succeeded. |
Loirooriol
approved these changes
Feb 23, 2026
| layout_context, | ||
| node_and_style_info, | ||
| NonReplacedContents::OfElement, | ||
| // TODO: This only works because currently PropagatedBoxTreeDataonly stores |
Contributor
There was a problem hiding this comment.
Suggested change
| // TODO: This only works because currently PropagatedBoxTreeDataonly stores | |
| // TODO: This only works because currently PropagatedBoxTreeData only stores |
| ); | ||
| self.base.clear_fragments_and_fragment_cache(); | ||
| *self.base.cached_inline_content_size.borrow_mut() = None; | ||
| self.base.repair_style(&node_and_style_info.style); |
Contributor
There was a problem hiding this comment.
Might be worth investigating changing TableSlotCell to have an IndependentFormattingContext, even if the contents will always be IndependentFormattingContextContents::Flow() (at least for now, but see w3c/csswg-drafts#3940).
servo-highfive
removed
the
S-awaiting-review
These two types of boxes should also be able to isolate damage during propagation and serve as roots for box tree reconstruction, as their contents are independent of their containing box. Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Luke Warlow <lwarlow@igalia.com>
mrobinson
force-pushed
the
extend-box-tree-damage-isolation-to-tables
branch
from
365651d to
7bac756
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two types of boxes should also be able to isolate damage during
propagation and serve as roots for box tree reconstruction, as their
contents are independent of their containing box.
Testing: This should not change testable behavior so is covered by existing WPT tests.