script: Pass &mut JSContext in FetchResponseListener::process_response_eof#42729
Merged
kkoyung merged 2 commits intoservo:mainfrom Feb 20, 2026
Merged
script: Pass &mut JSContext in FetchResponseListener::process_response_eof#42729kkoyung merged 2 commits intoservo:mainfrom
&mut JSContext in FetchResponseListener::process_response_eof#42729kkoyung merged 2 commits intoservo:mainfrom
Conversation
…onse_eof` Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
servo-highfive
added
the
S-awaiting-review
sagudev
changed the title
FetchResponseListener::process_response_eof&mut JSContext in FetchResponseListener::process_response_eof
kkoyung
approved these changes
Feb 20, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
simonwuelker
pushed a commit
to simonwuelker/servo
that referenced
this pull request
Feb 23, 2026
…ponse_eof` (servo#42729) `process_response_eof` is the only method that needs cx at least right now. This PR removes one temp_cx and introduces one, removing that one will is hard (needs VirtualMethods and a lot of work) Testing: Just refactor Part of servo#40600 --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_response_eofis the only method that needs cx at least right now. This PR removes one temp_cx and introduces one, removing that one will is hard (needs VirtualMethods and a lot of work)Testing: Just refactor
Part of #40600