script: Implement remaining query command methods#42748
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Feb 22, 2026
Merged
script: Implement remaining query command methods#42748TimvdLippe merged 1 commit intoservo:mainfrom
TimvdLippe merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
|
🔨 Triggering try run (#22275245084) for Linux (WPT) |
TimvdLippe
force-pushed
the
implement-query-command-methods
branch
from
0352cea to
c268bdf
Compare
|
|
TimvdLippe
force-pushed
the
implement-query-command-methods
branch
from
c268bdf to
5dc55ba
Compare
Contributor
|
Lines changed: 30800 additions & 198611 deletions minimal removed 30,000 lines of diff... |
sebsebmc
requested changes
Feb 22, 2026
servo-highfive
added
S-needs-code-changes
This implements a baseline for these tests. By implementing these dummy methods, we avoid a lot of test expectation clutter when debugging these tests to figure out why they aren't passing yet. For the delete command, since it doesn't have any state or is indeterminate, we always return the same. Part of servo#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
TimvdLippe
force-pushed
the
implement-query-command-methods
branch
from
5dc55ba to
6834a4c
Compare
servo-highfive
added
S-awaiting-review
sebsebmc
approved these changes
Feb 22, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
simonwuelker
pushed a commit
to simonwuelker/servo
that referenced
this pull request
Feb 23, 2026
This implements a baseline for these tests. By implementing these dummy methods, we avoid a lot of test expectation clutter when debugging these tests to figure out why they aren't passing yet. For the delete command, since it doesn't have any state or is indeterminate, we always return the same. Part of servo#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a baseline for these tests. By implementing these dummy methods, we avoid a lot of test expectation clutter when debugging these tests to figure out why they aren't passing yet.
For the delete command, since it doesn't have any state or is indeterminate, we always return the same.
Part of #25005